Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different line termination in organization name #67

Open
bvhme opened this issue Feb 15, 2021 · 1 comment
Open

Different line termination in organization name #67

bvhme opened this issue Feb 15, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bvhme
Copy link
Member

bvhme commented Feb 15, 2021

Since #61 removed the non-breaking spaces from the name of the organization it has been terminating as follows:

image

Suggested solution: enforce UTF-8 encoding and add the non-breaking spaces back. Alternatively, hard code dimensions.

We could also think about removing the requirement for where we want to break.

@Ainali Ainali added the bug Something isn't working label Feb 15, 2021
@angelplasma
Copy link
Member

angelplasma commented Feb 15, 2021

@bvhme Agree iteration can/should improve. The non-breaking spaces were rendering incorrectly when the site was rebuilt (reason unclear), even though title string was untouched. Hence their removal.

I favor and will implement solution 2 below, if no further feedback received

  1. Reinsert non-breaking spaces (Maintains previous solution)
  2. Forcing line-break when needed using spans, as shown below (Enables larger font + right-side nav at lower window widths)
  3. Hardcoding element dimensions (Slightly brittle, but workable)

SiteTitle_v02

<p>
<span style="white-space:nowrap;">Foundation for</span>
<span style="white-space:nowrap;">Public Code</span>
</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants