Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: adjust the connect wallet button so that it's width is not constrained on certain mobile devices #151

Open
salieflewis opened this issue Apr 11, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@salieflewis
Copy link
Contributor

IMG_3421

@salieflewis
Copy link
Contributor Author

Been messing around with troubleshooting this issue in a specific branch salief/connect-constraint. Can't seem to figure out how to crack it, it's specifically weird because the issue doesn't appear when in responsive design mode when developing locally. Been pushing commits and periodically checking on my phone to see how they effect things.

When the ConnectButton component is not wrapped in DropdownMenu.Item this issue goes away, but we revisit the issue where the Auction sheet or mobile menu won't close when trying to connect your wallet.

Thoughts? @0xTranqui

@0xTranqui
Copy link
Member

could you not unwrap the button and add an onClick={setOpen(false)} to it to manually cause the modal close on connection/disonnection?

@salieflewis salieflewis added the bug Something isn't working label Apr 12, 2023
@calebguy
Copy link
Contributor

Looking good on safari and chrome, @salieflewis possibly this was resolved previously?

image

image

@salieflewis
Copy link
Contributor Author

This may just be an issue on older devices. I'm rocking an 8 Plus and it looks like this for me.

IMG_B767481BDFBC-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants