-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: pending proposals should go in the "active" section #111
Comments
Wouldn't say it needs to be changed. I don't consider "Pending" to be active in regards to the user. We made this page to be action oriented, so the top section is meant only for proposals the user needs to take action on (Active). When you are in a DAO with a lot of proposals, that whole area becomes even more valuable- especially without filtering for now. @0xTranqui |
There are multiple actions that need to be taken when a proposal is not "active", which is the sentiment behind what I was saying. If they dont feel of the same importance and thus shouldnt be above the fold, thats a decision we could make, just pointing it out. In the first days when a proposal is in "pending" phase is when a lot of the governance dialogue should theoretically be happening, so feels like it would be smart/safe for us to put that over the fold as well so ppl dont miss those. Actions that can be taken when proposal is not in "active" phase:
|
Great points @0xTranqui ! I was under the impression for this build we wouldn't be able to customize the proposal feed per wallet address. Which means (please correct me I may be wrong)- for example, the only person who can cancel is the one who created the proposal? If that's correct, it would be beneficial for one user to have that info above the fold (action oriented), and not all. Until we are able to integrate individual experiences on the feed (proposals you created) and filtering, that may be pretty confusing for PENDING to be up there. If we ARE able to integrate individual experiences on proposals, than Max's suggestions make more sense. Additionally - I could also be wrong again - do proposals move to the "QUEUED" Status after the Pending phase? Maybe it makes sense to move QUEUED above the fold right now rather than PENDING |
States: 1. Pending (can be canceled here) 2. Active (can be defeated here) 3. Queued (can be vetoed here, executable if it reaches the end of Queued phase without getting vetoed) Regarding customizing the feed, I imagine we didn't do that because most ppl wont be logged in at that point, so wed need to be making a decision that affects everyone. I'd aire (air?) on the side of caution by providing too much info (letting ppl know something is coming up for vote in x days once pending is completed), but yea thats the tradeoff there. On the proposal page view we should be able to include custom states based on wallet connect, as thats already happening with the ability to Submit Vote being unlocked on active proposals when a user with the requisite voting power signs in. Logic should function the same way for these other states we are discussing, and YES only submitter can CANCEL, only Veto holder can VETO, and ANYONE can execute proposal once it reaches that stage |
This is ripe discussion here. I kinda agree with Max that PENDING proposals should go above the fold, as well as QUEUED. Perhaps we can change the word 'Active' to something else? Perhaps 'In Progress'? Thoughts? @losingmyego @0xTranqui |
Moving all those states into that top area means the design needs to be re-evaluated and redone. This cannot be overlooked or understated. I also realize now - are the "Vote needed" Tags being included next to the Active state for props a user hasn't voted on? This was meant to be an area that solely highlighted proposals that need a vote, because we realized in a DAO with a lot of props it can be hard to recognize which you haven't voted on. Including half the available states makes no sense in the current design. This was the solution due to limited time allotted for UX + wireframing, so if we are willing to push back launch to re-evaluate the whole page than we can do so. The reason I suggested QUEUED to also be included is because there is a deadline on execution, which is just as important as a vote. If we are moving all those card states to the top, there's not a valid reason for having that top area designed as it currently is. There are way too many nuanced states that need to be taken into consideration, and the sizing doesn't make sense for cards that don't require something for the user - so I would say if there's opposition than delete it fully and go back to the normal feed for everything, which is a better alternative for this version |
Hi @losingmyego sitting here with @0xTranqui now trying to figure out how to resolve this issue. The suggestion that we're bringing to you is to change the 'ACTIVE' ticker (adjacent to 'TOTAL') to say 'IN PROGRESS' and push proposals that are in any state other than 'EXECUTED', 'DEFEATED', 'CANCELED', or 'VETOED', above the fold. While a full redesign seems preferable, this seems like a positive transitionary step that solves the issue of critical governance scenarios not being brought to the users' attention (ex: a very controversial proposal in the 'QUEUED' state where everyone is waiting to hear on a veto). Thoughts? |
its a great intermediary solution until we're able to do a redesign, thanks for thinking it out @salieflewis @0xTranqui |
not sure if this is a bug or not but calling out the fact that this "pending" proposal that I submitted just now is appearing below the cut off of active/non-active. imo it makes most sense for proposals that are in any part of the governance process to show up in the above the fold cut off (this would mean pending, "active", queued). up for debate but think it makes sense
cc @salieflewis @losingmyego
The text was updated successfully, but these errors were encountered: