Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Factory Deploy Inputs #8

Open
0xTranqui opened this issue Oct 2, 2022 · 2 comments
Open

Clarification on Factory Deploy Inputs #8

0xTranqui opened this issue Oct 2, 2022 · 2 comments

Comments

@0xTranqui
Copy link
Member

0xTranqui commented Oct 2, 2022

@iainnash could you please clarify exactly what inputs we want to be passing into the "rendererInitializer" bytes param (line 40 of this the factory contract)? Was able to successfuly deploy a contract using "0x0000000000000000000000000000000000000000000000000000000000000000" as the value for this, but not actually sure what this is supposed to be.

From an initial read it looks like its supposed to be an abi.encoded string of the baseURI? Clarity would be great here so we get the factory UI running correctly

cc @salieflewis

@iainnash
Copy link
Contributor

iainnash commented Oct 2, 2022

I can add a method that leaves out some of these parameters but you can safely call this with empty bytes '' and address(0x0). This sets the renderer to the default parameters.

@iainnash
Copy link
Contributor

iainnash commented Oct 7, 2022

Should be good to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants