Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional curation target types #34

Open
dblodorn opened this issue Nov 29, 2022 · 1 comment
Open

Additional curation target types #34

dblodorn opened this issue Nov 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@dblodorn
Copy link

dblodorn commented Nov 29, 2022

Would be interesting to support (or explicitly type) curation of

  • transaction hashes: imagine it would be quite interesting to view a collection of novel transactions (fund transfers) deploys, etc. 🤷‍♂️
  • Block number... again not exactly sure why, but this seems to be an interesting data point that could be collated in compelling ways.

https://github.com/public-assembly/curation-protocol/blob/main/src/interfaces/ICurator.sol#L8-L21

@dblodorn dblodorn added the enhancement New feature or request label Nov 29, 2022
@0xTranqui
Copy link
Member

so I think this would be really cool and totally represent meaningful blockchain data to curate, however there is an issue with adding this functionality for a few reasons:

  1. see screenshot below for what information is stored in the listing struct. as of now, all Curation Types have an address component (line 26 of ICurator.sol). as listings allow u to curate bytes data (transaction hashes) or uints (block numbers), we would need to allow for the curation of other solidity data types, which would require foundational changes into how data is stored.

Screen Shot 2022-11-29 at 8 11 24 PM

  1. this could potentially be addressed by extracting curation types + listing structs out of the curation protoocl and into external onchain registries (like we did for access control), but that is a significant rewrite of the current architecture

am very open to this, but initial thinking at solution would require something pretty significant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants