Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of Curator.sol to ERC721Curator.sol? #26

Open
0xTranqui opened this issue Oct 6, 2022 · 2 comments
Open

Change name of Curator.sol to ERC721Curator.sol? #26

0xTranqui opened this issue Oct 6, 2022 · 2 comments

Comments

@0xTranqui
Copy link
Member

This idea just came up while working on the readme. I think this could be really helpful for making the nft architecture of everything more obvious to devs specifically. One hold up is that it might inadvertently make ppl think u can only curate ERC721s. What say you @iainnash ??

@iainnash
Copy link
Contributor

iainnash commented Oct 7, 2022

It's a little confusing imo because the curation contract can curate individual NFTs, 1155s, or even wallets. It itself being 721 compliant is a bonus perhaps not a core part of its functionality?

@0xTranqui
Copy link
Member Author

good points -- I agree lets leave as is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants