-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename v0.3 Range into BoundedRange #123
Comments
Sounds good! |
Hi, I would like to work on this issue. |
Hi @Michaelin007 thanks for your interest in this! The upgrade guide currently lives in the pubgrub-rs/guide repo, in a pull request I did not finish. pubgrub-rs/guide#6 You might have to coordinate with @Eh2406 and @charliermarsh who started reading that guide and leaving some comments. I'm not currently working on the guide so no need to coordinate with me. I'm happy to answer questions though. |
Hi @mpizenberg noted. |
Let's focus on making the change here. We can deal with updating the guide once the code has been changed. |
With the version-ranges crate split out (#262), the type's main name is now |
I'm currently writing the v0.2 -> v0.3 upgrade guide and realizing we still have the name
Range
for our default impl ofVersionSet
. However, this is not exactly the same as the previous v0.2Range
.So to prevent user confusion, and also make the upgrade guide clearer, I'd suggest we rename it to
BoundedRange
.That's also more precise since it's a range built with inclusive/exclusive bounds.
The text was updated successfully, but these errors were encountered: