Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Creating Custom egg and Docker image #556

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

QuintenQVD0
Copy link
Contributor

This PR is not perfect I do know that.

But changes in this pr

  • mention how the pterodactyl install proces works (with the /mnt/server and /home/container)
  • mention that no files can be in the docker container
  • give an example on how to use the file parser
  • mention how to use variables in the file parser
  • mention how to set multiple done lines
  • change the the java 17 example dockerfile and entrypoint
  • mention that we now mosty use debian based image and not alpine anymore
  • mention the requirement of the package iproute2 for the ip command

@QuintenQVD0
Copy link
Contributor Author

I have no idea wy the github build faild

Copy link
Contributor

@Jcodeerd Jcodeerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos and improvements

community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_image.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_image.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_image.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
community/config/eggs/creating_a_custom_egg.md Outdated Show resolved Hide resolved
@QuintenQVD0
Copy link
Contributor Author

I found the issue, you can not without a code block use {{}}

So now I just made it look like this, what to be honest is still pritty good
afbeelding

@QuintenQVD0
Copy link
Contributor Author

Please hold off on merging this, I am going to add an egg featured section and explain some more on validation of egg variables. So that it meets #434

@danny6167
Copy link
Member

Thank you for all the work done on this so far.
I don't know if you plan to complete it or not, but as you've indicated that it's not ready to merge I'm converting it to a draft PR.

@danny6167 danny6167 marked this pull request as draft June 29, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants