Filename fixes #46
Merged
Filename fixes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 22, 2024 10:58
…a are now located under compiled_metadata rather than dataset_description, and the rules are triggered by encountered a datafile rather than a metadata object (since the rules must be applied to the fully compiled metadata object, whose inheritance depends on datafile location)
…lumns' to 'columnsMatchMetadata'
…eprecated in cases where the object is not a directory; stem and suffix are mutually exclusive, arbitraryNesting applies to all filename rules
bleonar5
requested review from
becky-gilbert,
okaycj and
ianchandlercampbell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #43 and represents the last major chunk of issue #25
I've consolidated the properties used to identify files in _findRuleMatches and factored out the match conditions to their own function, which hopefully makes things clearer and neater.
Some other minor changes include an update to the name for the property that indicates that a datafile's columns must match the "variableMeasured" property in the metadata. "columns" -> "columnsMatchMetadata"
I also included some miscellaneous updates to the default ignore list that I noticed in the process of development.
As for the big-picture issue regarding the difficulty syncing up psych-DS and psychds-validator versions during development, I realized that the simple and obvious solution to this is to actually make use of the "versions" that I've built into the schema_model repository. That is, when I make an update to the schema model from this point on, I will always make sure to add it in a new directory within the repo, with an incremented version number such as 1.X.X. With this, I can make sure that all psychds-validator branches point to specific versions of the schema model rather than always grabbing the 'latest' version.