Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer issue/error descriptions living in list.ts to schema model #30

Closed
bleonar5 opened this issue Jan 16, 2024 · 0 comments
Closed
Assignees
Labels
Scoping Discussion regarding the scope, design, and features of the psych-DS validator

Comments

@bleonar5
Copy link
Contributor

TL;DR

Certain errors/issues are currently listed in list.ts and ought to be moved to a suitable location in the schema model

Out of convenience relating to inherited code, I've ended up adding a number of floating issues/errors to list.ts in order to use the addNonSchemaIssue function to quickly develop necessary functionality in the validation process. Now that most key functionality is in place, and since the name of the game for this sprint is "updating schema model", it is now time to tackle this.

By the end of the process, there should no longer be any need for list.ts or the addNonSchemaIssue function, so these will be eliminated entirely, and all errors/issues will either simply be relocated to errors.yaml or collated directly with their relevant rules. Perhaps the best setup will be to reference error codes within the rule files and catalog the errors according to their codes in errors.yaml

This is essentially a sub-issue of #25

@bleonar5 bleonar5 added the Scoping Discussion regarding the scope, design, and features of the psych-DS validator label Jan 16, 2024
@bleonar5 bleonar5 self-assigned this Jan 16, 2024
@bleonar5 bleonar5 mentioned this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scoping Discussion regarding the scope, design, and features of the psych-DS validator
Projects
None yet
Development

No branches or pull requests

1 participant