Fix usage of clock and CLOCKS_PER_SEC
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtrujy
commented
Apr 6, 2024
| @@ -637,7 +637,7 @@ int _gettimeofday(struct timeval *tv, struct timezone *tz) | |||
|
|
|||
| #ifdef F__times | |||
| clock_t _times(struct tms *buffer) { | |||
| clock_t clk = GetTimerSystemTime() / (kBUSCLK / CLOCKS_PER_SEC); | |||
There was a problem hiding this comment.
Even being the same value, I think that using CLOCKS_PER_SEC could be "confusing"
fjtrujy
commented
Apr 6, 2024
| @@ -36,7 +36,7 @@ int main(int argc, char *argv[]) | |||
| struct timespec tv = {0}; | |||
| tv.tv_sec = 1; | |||
| tv.tv_nsec = 0; | |||
| error_tolerance = 5; // 5 miliseconds of error tolerance | |||
| error_tolerance = 200; // 200 miliseconds of error tolerance | |||
There was a problem hiding this comment.
There is room for improvement in the timer, we should be more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After fixing the implementation of
clock(), now it returns values inmicroseconds, so now we need to make some adjustments.Before mergin this PR we need to merge first ps2dev/newlib#12