Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf libraries #159

Open
mpwarres opened this issue Sep 11, 2023 · 2 comments
Open

Update protobuf libraries #159

mpwarres opened this issue Sep 11, 2023 · 2 comments
Assignees

Comments

@mpwarres
Copy link
Contributor

As pointed out in envoyproxy/envoy#29546, proxy-wasm-cpp-sdk is using v3.9.1 of the protobuf library, which is from 2019. We should update it.

@martijneken
Copy link
Contributor

martijneken commented Sep 13, 2023

+1 we should do this. I tried as part of my emsdk update (to fix a zlib issue) and I ran into some issues propagating copts: #157 (comment)

I propose we finish the emsdk update first, then try to bump protobuf.

@mpwarres
Copy link
Contributor Author

mpwarres commented Aug 4, 2024

Updating the protobuf library should make the hack mentioned in these instructions obsolete, since protobuf added support for building with Emscripten in protocolbuffers/protobuf@8e869f7.

As part of updating protobuf, the instructions linked above should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants