Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notebook should have project dependent setting as environment variables #8

Open
proppy opened this issue Aug 9, 2022 · 0 comments
Open

notebook should have project dependent setting as environment variables #8

proppy opened this issue Aug 9, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@proppy
Copy link
Owner

proppy commented Aug 9, 2022 •
edited
Loading

Variables:

  • PROJECT_ID
  • STAGING_BUCKET
  • ARTIFACT_REGISTRY
  • SILICON_DESIGN_IMAGE
  • LOCATION

That would allow us to get rid of the hardcoded value in the tuning and vizualization notebooks:
https://github.com/proppy/rad-lab/blob/tuning/modules/silicon_design/scripts/build/notebooks/xls/tuning.md#define-project-parameters
https://github.com/proppy/rad-lab/blob/tuning/modules/silicon_design/scripts/build/notebooks/xls/visualization.md#define-project-parameters
@proppy proppy added the bug Something isn't working label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@proppy