Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject project specific information to the notebook environment #14

Open
proppy opened this issue Sep 1, 2022 · 2 comments
Open

inject project specific information to the notebook environment #14

proppy opened this issue Sep 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@proppy
Copy link
Owner

proppy commented Sep 1, 2022

Currently we hardcode a lot of project specific information in the first cell of the tuning notebook:
https://github.com/proppy/rad-lab/blob/tuning/modules/silicon_design/scripts/build/notebooks/examples/digital/serv/tuning.md#define-project-parameters

it would be nice to inject them as environment variable instead in the container environment:

CONTAINER_IMAGE = 'us-east4-docker.pkg.dev/catx-demo-radlab/containers/silicon-design-ubuntu-2004:latest'
STAGING_BUCKET='catx-demo-radlab-staging'
PROJECT_ID = 'catx-demo-radlab'
LOCATION = 'us-central1'
MACHINE_TYPE = 'n1-standard-8'
@proppy proppy added the bug Something isn't working label Sep 1, 2022
@PiotrZierhoffer
Copy link

Some of these would make sense to be "current" settings - we're using the same container image, project id, probably location as the one that the tuning notebook is running in.

This would make it much easier to clone and deploy in your own project, just by adjusting the terraform files. I don't know if it's possible though.

@proppy
Copy link
Owner Author

proppy commented Sep 1, 2022

It doesn't seems that the terraform provider:
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/notebooks_instance#container_image
nor the underlying API:
https://cloud.google.com/vertex-ai/docs/workbench/reference/rest/v1beta1/projects.locations.instances#Instance
supports specifying the runtime environment of the notebook.

But we should be able to inject this in the container environment by using https://docs.docker.com/engine/reference/builder/#arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants