From 12eac536c2460478373e69347e1173c7974822b6 Mon Sep 17 00:00:00 2001
From: Johan Euphrosine <proppy@google.com>
Date: Thu, 22 Sep 2022 21:42:57 +0900
Subject: [PATCH] silicon/design: add data disk

---
 modules/silicon_design/main.tf      |  3 +++
 modules/silicon_design/variables.tf | 12 ++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/modules/silicon_design/main.tf b/modules/silicon_design/main.tf
index 1e4a15d6..326e8a4e 100644
--- a/modules/silicon_design/main.tf
+++ b/modules/silicon_design/main.tf
@@ -279,6 +279,9 @@ resource "google_notebooks_instance" "ai_notebook" {
   install_gpu_driver = false
   boot_disk_type     = var.boot_disk_type
   boot_disk_size_gb  = var.boot_disk_size_gb
+  data_disk_type     = var.data_disk_type
+  data_disk_size_gb  = var.data_disk_size_gb
+  no_remove_data_disk = true
 
   no_public_ip    = false
   no_proxy_access = false
diff --git a/modules/silicon_design/variables.tf b/modules/silicon_design/variables.tf
index 55fca5b1..a6e741c4 100644
--- a/modules/silicon_design/variables.tf
+++ b/modules/silicon_design/variables.tf
@@ -104,6 +104,18 @@ variable "create_budget" {
   default     = false
 }
 
+variable "data_disk_size_gb" {
+  description = "The size of the data disk in GB attached to this instance"
+  type        = number
+  default     = 1000
+}
+
+variable "data_disk_type" {
+  description = "Data disk types for notebook instances"
+  type        = string
+  default     = "PD_EXTREME"
+}
+
 variable "create_network" {
   description = "If the module has to be deployed in an existing network, set this variable to false. {{UIMeta group=2 order=1 }}"
   type        = bool