Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources に出現せず他の述語でも使われていないΔ述語を除去するようにした #47

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

cedretaber
Copy link
Collaborator

関連 issue: #45

概要

以前の実装では、 simplification の際にΔ述語は全て残すようにしていたが、この修正で、 sources のテーブル名と異なり、他の述語でも使われていないΔ述語は削除されるようになった。

確認方法

❯ dune exec bin/simplification.exe -- examples/simplification3_1.dl
source ps('A':int, 'B':int).           
view pv('A':int).
+ps(A, B) :- ps(GENV13, _) , not -ps(_, _) , not ps(A, _) , A = 4 , B = -100 , GENV13 = 1.
+ps(A, B) :- ps(GENV10, _) , ps(GENV2, B) , not ps(A, _) , A = 4 , GENV10 = 1 , GENV2 = 1.
-ps(A, B) :- ps(A, B) , A = 1.

@cedretaber cedretaber self-assigned this Aug 28, 2024
@hiroyukikato
Copy link
Collaborator

Thanks! LGTM.

@cedretaber cedretaber merged commit 05fa4ca into master Sep 11, 2024
4 checks passed
@cedretaber cedretaber deleted the fix-simplification-#1 branch September 11, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants