Fix NODEV errors on Thinkpad when parsing battery status #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Sinister <[email protected]>
marvin-sinister
force-pushed
the
ignore-nodev
branch
from
fe26935
to
a4a7781
Compare
|
LGTM, although, it seems to be only some thinkpads. My X1 Carbon seems to work OK for this file. |
discordianfish
approved these changes
May 27, 2024
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go
May 31, 2024
…5453) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs) | `v0.15.0` -> `v0.15.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/procfs (github.com/prometheus/procfs)</summary> ### [`v0.15.1`](https://togithub.com/prometheus/procfs/releases/tag/v0.15.1) [Compare Source](https://togithub.com/prometheus/procfs/compare/v0.15.0...v0.15.1) #### What's Changed - Fix NODEV errors on Thinkpad when parsing battery status by [@​marvin-sinister](https://togithub.com/marvin-sinister) in [https://github.com/prometheus/procfs/pull/641](https://togithub.com/prometheus/procfs/pull/641) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/procfs/pull/642](https://togithub.com/prometheus/procfs/pull/642) - Return support for Go 1.20 by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/procfs/pull/645](https://togithub.com/prometheus/procfs/pull/645) - enable testifylint linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/procfs/pull/643](https://togithub.com/prometheus/procfs/pull/643) #### New Contributors - [@​marvin-sinister](https://togithub.com/marvin-sinister) made their first contribution in [https://github.com/prometheus/procfs/pull/641](https://togithub.com/prometheus/procfs/pull/641) - [@​mmorel-35](https://togithub.com/mmorel-35) made their first contribution in [https://github.com/prometheus/procfs/pull/643](https://togithub.com/prometheus/procfs/pull/643) **Full Changelog**: prometheus/procfs@v0.15.0...v0.15.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jun 4, 2024
](https://renovatebot.com){kind=link}
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/procfs](https://togithub.com/prometheus/procfs) | `v0.15.0` -> `v0.15.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/procfs (github.com/prometheus/procfs)</summary> ### [`v0.15.1`](https://togithub.com/prometheus/procfs/releases/tag/v0.15.1) [Compare Source](https://togithub.com/prometheus/procfs/compare/v0.15.0...v0.15.1) #### What's Changed - Fix NODEV errors on Thinkpad when parsing battery status by [@​marvin-sinister](https://togithub.com/marvin-sinister) in [https://github.com/prometheus/procfs/pull/641](https://togithub.com/prometheus/procfs/pull/641) - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [https://github.com/prometheus/procfs/pull/642](https://togithub.com/prometheus/procfs/pull/642) - Return support for Go 1.20 by [@​SuperQ](https://togithub.com/SuperQ) in [https://github.com/prometheus/procfs/pull/645](https://togithub.com/prometheus/procfs/pull/645) - enable testifylint linter by [@​mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/prometheus/procfs/pull/643](https://togithub.com/prometheus/procfs/pull/643) #### New Contributors - [@​marvin-sinister](https://togithub.com/marvin-sinister) made their first contribution in [https://github.com/prometheus/procfs/pull/641](https://togithub.com/prometheus/procfs/pull/641) - [@​mmorel-35](https://togithub.com/mmorel-35) made their first contribution in [https://github.com/prometheus/procfs/pull/643](https://togithub.com/prometheus/procfs/pull/643) **Full Changelog**: prometheus/procfs@v0.15.0...v0.15.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM4OC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On thinkpads, reading
power_supply class charge_control_end_thresholdreturnsno such deviceerror, which results in battery metrics not being exported.Fixes: prometheus/node_exporter#3019