fix!: Prevent tampering bypass by changing error handling #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This whole section would've been bypassable by just doing: ``error = function() return end`` * Change to return print
ccuser44
reviewed
Oct 29, 2024
| @@ -105,7 +105,7 @@ function AntiTamper:apply(ast, pipeline) | |||
| end | |||
| code = code .. [[ | |||
| local gmatch = string.gmatch; | |||
| local err = function() error("Tamper Detected!") end; | |||
| local err = function() return print("Tamper Detected!") end; | |||
There was a problem hiding this comment.
This is good but a better way would be to replace the code with while true do end to cause an infinite loop to prevent any further code from running, albeit that could lead to crashes. And have the print in front of the while loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This whole section would've been bypassable by just doing:
error = function() return end