Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use case: service_restart_total only #35

Open
belm0 opened this issue Jul 21, 2020 · 3 comments
Open

use case: service_restart_total only #35

belm0 opened this issue Jul 21, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@belm0
Copy link

belm0 commented Jul 21, 2020

I'm currently using node_exporter and have this issue, so raising it here as well.

Metrics like unit_state are quite costly due to cardinality. In my case with node_exporter it's consuming about ~15% of our entire metric space, affecting scrape times, caching nodes, etc.

My use case requires service_restart_total only, so ideally I'd have a way to disable unit_state and various other default metrics.

@povilasv
Copy link
Contributor

👍 I think we should add a disable/enable flag for it, like we have it in https://github.com/povilasv/systemd_exporter/blob/master/systemd/systemd.go#L32

@povilasv povilasv added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 23, 2020
@belm0
Copy link
Author

belm0 commented Jul 23, 2020

@povilasv In the metric table of the README, it would be helpful to have a column indicating which enable flag, if any, controls the metric.

Are you proposing an enable flag for unit_state only? It might be OK for my use case, depending on how many metrics remain by default.

@povilasv
Copy link
Contributor

I think more like disable flag for unit_state and then let's see if there is another chatty metric, we need a disable flag for ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants