Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different behavior between apply and commit (in terms of return code) #74

Open
asarubbo opened this issue Sep 8, 2022 · 0 comments
Open

Comments

@asarubbo
Copy link

asarubbo commented Sep 8, 2022

Suppose we run nattka on something that was already done/handled:

At the time of writing, arm64 was done in bug 869125:

apply:

 ~ $ nattka apply -a arm64 869125 ; echo $?
0

commit:

 ~ $ nattka commit -a arm64 869125 ; echo $?
ERROR:nattka:Bug 869125: no packages match requested arch
1

resolve:

 ~ $ nattka resolve -a arm64 869125 ; echo $?
WARNING:nattka:Bug 869125: no specified arches CC-ed, found: ppc ppc64
0

To have the same behavior everywhere, commit should return 0, or apply and resolve should return 1

Since the workflow is apply -> commit -> resolve, another solution can be implement something on apply (like pretend?) that inform in whatever way if you are doing something doable or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant