-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type annotations: Replace Union[a, b] with a | b, Optional[a] with a | None #1341
Comments
pyupgrade should be able to do that automatically (by running |
Hey @EwoutH, Is this still open? |
I noticed this issue hasn't been updated in a while. Is it still relevant and open for contributions? Specifically, I'm interested in working on #1341. |
Still not applicable, because the oldest supported Python is still 3.9: Line 9 in 665aebc
|
According to SPEC 0 we could drop Python 3.9 support already. But since Python 3.9 is still quite well supported (also by NumPy for example), I would propose keeping it for a bit until Mesa 2.3 is released. Then for 2.4 or 3.0 we can drop 3.9 and require 3.10+. @Aryan1Mahahjan you could already make an PR, make sure it's passing on the current CI for Python 3.10 and higher. But you might need to update the PR in a few months. Note that pyupgrade can probably already do a part of the work. |
Hi everyone! I also want to contribute and learn but i am new to this platform please guide me . Email:- [email protected] |
Looks like it is possible to do it even on Python older than 3.10. See projectmesa/mesa-geo#67 (comment).
Update: from implementing #1345, looks like older Pythons don't support type aliases with
|
yet. For this issue to be completely resolved, we need to wait until 3.10 is the oldest supported version.The text was updated successfully, but these errors were encountered: