Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDIDiscoveryClient is not thread-safe #46

Open
peacekeeper opened this issue Apr 13, 2016 · 0 comments
Open

XDIDiscoveryClient is not thread-safe #46

peacekeeper opened this issue Apr 13, 2016 · 0 comments
Assignees
@peacekeeper
Labels
bug

Comments

@peacekeeper
Copy link
Member

one instance of XDIDIscoveryClient reuses a single XDIHttpClient, which is itself not thread-safe due to the use of the httpURLConnection member and the design of the connect() and disconnect() methods

as a workaround, create a new XDIDIscoveryClient every time it is needed (or at least a separate one per thread)
@peacekeeper peacekeeper self-assigned this Apr 13, 2016
kvats added a commit to RespectNetwork/sdk-csp that referenced this issue Apr 15, 2016
@kvats
https://github.com/projectdanube/xdi2/issues/46
14fd7e4
kvats added a commit to RespectNetwork/cynja-cloud-chat that referenced this issue Apr 15, 2016
@kvats
Workaround fix for projectdanube/xdi2#46
d80fe9b
kvats added a commit to kvats/xdi2 that referenced this issue Apr 22, 2016
@kvats
Bug Fix: projectdanube#46
9802edc
kvats added a commit to RespectNetwork/xdi2 that referenced this issue Jun 8, 2016
@kvats
Bug Fix: projectdanube#46
ab68787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peacekeeper peacekeeper

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peacekeeper