Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analysis): add path attribute / mixin to structural models #1570

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

winged
Copy link
Contributor

@winged winged commented Sep 29, 2021

Part of a series of PRs that will lead to the analysis module: #1569

Add a denormalisation step to the structural data models (case, workitem,
and document) that will allow faster queries across case structures down
the road.

The `sender` attribute in signal handlers is special, as it will
always be sent, and is thus not part of the `kwargs`. However it
still makes sense to allow access to the sender in the `filter_events()`
predicates
@winged winged force-pushed the feat_path branch 3 times, most recently from 273cd7c to fac557c Compare September 30, 2021 08:42
@winged winged force-pushed the feat_path branch 2 times, most recently from 6d081a1 to b3501a3 Compare September 30, 2021 09:01
@winged winged marked this pull request as ready for review September 30, 2021 09:01
@winged winged requested a review from czosel September 30, 2021 09:01
Copy link
Member

@open-dynaMIX open-dynaMIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🎉

Just minor nitpicks.

caluma/caluma_core/models.py Outdated Show resolved Hide resolved
caluma/caluma_core/tests/test_set_path.py Outdated Show resolved Hide resolved
Part of a series of PRs that will lead to the analysis module.

Add a denormalisation step to the structural data models (case, workitem,
and document) that will allow faster queries across case structures down
the road.
@winged winged merged commit 118658e into projectcaluma:master Oct 4, 2021
@winged winged mentioned this pull request Oct 4, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants