Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New initial section on requirements, as suggested by @ebeshero. #259

Closed
wants to merge 1 commit into from

Conversation

martindholmes
Copy link
Collaborator

I've just followed @ebeshero's suggestion in issue #224 to add an initial section setting out requirements.

@martindholmes martindholmes added the documentation Improvements or additions to documentation label Nov 29, 2022
@joeytakeda
Copy link
Contributor

Looks good to me--thanks! Just wanted to confirm that we wanted to merge this into dev, right? (If that's the case, then just feel free to merge :-)

@ebeshero
Copy link

ebeshero commented Dec 1, 2022

@martindholmes @joeytakeda looks good to me as well! It didn't need to be a lot, but it's good to ensure we know going in what Windows will require. Indeed I'm pretty sure there's a reasonable ant solution to the Windows filepath trouble, so I hope we'll revisit that... I never did test pathconvert but I'd like to try it. Meanwhile, my students are implementing staticSearch on a project website on our college history--an archive of revised/polished up semester projects from earlier classes they took in the past couple of years. It should be ready to share as they wrap up work in a couple of weeks!

@martindholmes
Copy link
Collaborator Author

Since Windows is now supported, this must be revised before merging.

@martindholmes
Copy link
Collaborator Author

If we add ant-contrib (issue #260) to the repo, then we'll have to remove that bit as well.

Copy link
Collaborator Author

@martindholmes martindholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to kill this and just edit directly in dev, since we're now supporting Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants