GitHub Release Action Fixes #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedhtchang
reviewed
Jul 7, 2023
tedhtchang
reviewed
Jul 7, 2023
tedhtchang
reviewed
Jul 8, 2023
anishasthana
force-pushed
the
fix_release_action
branch
from
27b30c9
to
964a0e7
Compare
tedhtchang
reviewed
Jul 10, 2023
jiripetrlik
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Thank you @anishasthana for the improvements. I have one comment.
This fixes a few issues that were discovered in the CodeFlare 0.0.5 release 1. Tag image as stable, not latest. We have switched over to using podman as well 2. Update github release step to include release notes 3. Move github tag + release step to end Signed-off-by: Anish Asthana <[email protected]>
Co-authored-by: ted chang <[email protected]>
Signed-off-by: Anish Asthana <[email protected]>
anishasthana
force-pushed
the
fix_release_action
branch
from
b01878c
to
5729708
Compare
|
@MichaelClifford @Maxusmusti can I get eyes on this PR? |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues that were discovered in the CodeFlare 0.0.5 release
vas part of the tag for consistency