Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect description of git pull behavior in Chapter 3.5 of Pro Git book V2 #1962

Open
3 of 5 tasks
Manimestro opened this issue Jun 23, 2024 · 0 comments
Open
3 of 5 tasks
Labels

Comments

@Manimestro
Copy link

There's no existing/similar bug report.

  • I have searched the existing issues

This report is about a single actionable bug.

  • I'm reporting a single actionable bug

This report is about the ProGit book, version 2, English language.

  • This bug is not about a translation or old version

Bug covers book website/pdf

  • I confirm the bug is about the book as found on the website/pdf

Problem is present in the Pro Git book on the website?

  • This bug also affects the Pro Git book as published on the website.

Which version of the book is affected?

Source files

Describe the bug:

The Pro Git v2 book contains a misleading statement about the behavior of git pull in Chapter 3.5
link: https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches

The current statement is:

"git pull will look up what server and branch your current branch is tracking, fetch from that server and then try to merge in that remote branch."

This implies that the merge happens in the remote branch, which is incorrect. The correct behavior is that the merge happens in the local branch.

Steps to reproduce:

  1. Go to https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches
  2. Scroll down to "Pulling" section
  3. See error

Expected behavior:

Current Statement:
"git pull will look up what server and branch your current branch is tracking, fetch from that server and then try to merge in that remote branch."

Corrected Statement:
"git pull will look up which server and branch your current branch is tracking, fetch from that server, and then try to merge that remote branch into your current local branch."

Screenshots:

Screenshot 2024-06-23 at 13 24 02

Additional context:

Location:
Chapter 3.5, Section Pulling
Link: https://git-scm.com/book/en/v2/Git-Branching-Remote-Branches

Device

desktop

Operating system

macos

Browser/application + version

google chrome

@Manimestro Manimestro added the bug label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant