Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to setup settings fluently #988

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add methods to setup settings fluently #988

merged 1 commit into from
Oct 11, 2024

Conversation

geirolz
Copy link
Collaborator

@geirolz geirolz commented Sep 19, 2024

Adds some methods, just aliases to copy, to setup settings fluently.

I have two doubts:

  • Is it better to use with or as ?
  • Is it better to accept booleans instead of Durable/NonDurable, etc.. ? Like .withDurable(true)

@geirolz geirolz self-assigned this Sep 26, 2024
matejcerny
matejcerny approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@matejcerny matejcerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference is to not use booleans.

@geirolz geirolz merged commit 3cc1285 into master Oct 11, 2024
3 checks passed
@geirolz geirolz deleted the Add-syntax-to-improve-usability branch October 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcerny matejcerny matejcerny approved these changes

Assignees

@geirolz geirolz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geirolz @matejcerny