Added automaticTopologyRecovery to Fs2RabbitConfig #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geirolz
reviewed
Sep 3, 2024
| @@ -57,6 +58,7 @@ object Fs2RabbitConfig { | |||
| internalQueueSize: Option[Int], | |||
| requestedHeartbeat: FiniteDuration = FiniteDuration(ConnectionFactory.DEFAULT_HEARTBEAT, TimeUnit.SECONDS), | |||
| automaticRecovery: Boolean = true, | |||
| automaticTopologyRecovery: Boolean = true, | |||
There was a problem hiding this comment.
This is the default value for the java library, I suppose, is it not?
There was a problem hiding this comment.
Yes, in "modern" versions of that library.
There was a problem hiding this comment.
Yea, I mean - the one we are using in fs2-rabbit at least
This isn't a problem I'd say |
|
P.S. Ignore the CI error, there is a PR to fix it and it isn't related to your changes |
geirolz
approved these changes
Sep 3, 2024
matejcerny
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopologyRecovery feature in amqp-client is sometimes strange. I prefer to have it disabled. This PR adds the needed configuration option to Fs2RabbitConfig.
This change is not backwards compatible in Fs2RabbitConfig constructor. It is not possible to add a default - only one apply method can have defaults defined. I could try to add some additional methods to keep compability.
Also, I fixed a small compilation error (unrelated).