Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for AR 7.2 and remove upper version limit #44

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Add tests for AR 7.2 and remove upper version limit #44

merged 3 commits into from
Sep 17, 2024

Conversation

jhollinger
Copy link
Contributor

@jhollinger jhollinger commented Sep 4, 2024 •
edited
Loading

Resolves #39:

  • Remove the AR upper version limit so people can at least try against new versions
  • Adds tests for AR 7.2

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@jhollinger jhollinger requested a review from a team as a code owner September 4, 2024 14:25
@jhollinger jhollinger marked this pull request as draft September 4, 2024 14:43
@jhollinger jhollinger marked this pull request as ready for review September 4, 2024 14:45
@jhollinger jhollinger merged commit 66743d7 into main Sep 17, 2024
7 checks passed
@jhollinger jhollinger deleted the remove-upper-version-limit branch September 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmccarthypdx ryanmccarthypdx ryanmccarthypdx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump dependency to allow Rails 7.2 upgrade
2 participants
@jhollinger @ryanmccarthypdx