Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing all headers is causing a 403 when deploying to AWS lambda #153

Open
gr2m opened this issue Jun 24, 2020 · 5 comments
Open

Passing all headers is causing a 403 when deploying to AWS lambda #153

gr2m opened this issue Jun 24, 2020 · 5 comments

Comments

@gr2m
Copy link
Contributor

gr2m commented Jun 24, 2020

By default, smee-client sends all headers:

{
  host: 'smee.io',
  connection: 'close',
  'user-agent': 'GitHub-Hookshot/ab308e1',
  accept: '*/*',
  'x-github-delivery': '7daaa700-b656-11ea-84ee-565013bbff02',
  'x-github-event': 'installation',
  'x-hub-signature': 'sha1=49d7...,
  'content-type': 'application/json',
  'x-request-id': '0e111...,
  'x-forwarded-for': '140.82.115.152',
  'x-forwarded-proto': 'https',
  'x-forwarded-port': '443',
  via: '1.1 vegur',
  'connect-time': '5',
  'x-request-start': '1593029318666',
  'total-route-time': '0',
  'content-length': '2937',
  timestamp: 1593029318680
}

When I only pass on the headers I care about (["x-github-delivery", "x-github-event", "x-hub-signature"]), then the error goes away.

I don't have time to investigate further right now, I'm creating this as a reminder :)

@issue-label-bot issue-label-bot bot added the bug label Jun 24, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stale
Copy link

stale bot commented Oct 4, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Oct 4, 2020
@gr2m gr2m added the pinned label Oct 4, 2020
@stale stale bot removed the wontfix label Oct 4, 2020
@cortexcompiler
Copy link

I would guess it might not like the host header, especially if going through API Gateway.

@topikachu
Copy link

Is it safe to delete the host header? I meet the same issue when the target is not the same host as the proxy host.

@Emanjbr

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants