Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added grid approximation #968

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Added grid approximation #968

merged 3 commits into from
Jun 30, 2022

Conversation

karm-patel
Copy link
Collaborator

Description

  1. Added grid approximation (code by Prof. @nipunbatra ) in notebooks/book1/04/laplace_approx_beta_binom_jax.ipynb which is also used in Book2
  2. notebooks/book2/07/advi_beta_binom_pymc.ipynb: Converted pymc3 to pymc4
  3. notebooks/book1/04/laplace_approx_beta_binom_pymc4.ipynb: currently this version is not working due to issue: Numerical differences between 3.11.4 and 4.0.0b pymc-devs/pymc#5443, So I have also kept pymc3 version for the same.

Figure Number

Book2: 7.2
Book1: 4.22

Figures

Before PR:
image

After PR:
image

Issue

#943

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Jun 30, 2022

Needs black formatting :)

@karm-patel karm-patel changed the title Grid2 Added grid approximation Jun 30, 2022
@karm-patel
Copy link
Collaborator Author

karm-patel commented Jun 30, 2022 •
edited
Loading

Needs black formatting :)

My bad! Fixed it.

@murphyk murphyk merged commit 2d93551 into probml:master Jun 30, 2022
@karm-patel karm-patel mentioned this pull request Jul 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karm-patel @murphyk