Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: stability of irmaclient.Client.jobs mechanism #366

Open
ivard opened this issue Dec 13, 2023 · 0 comments
Open

Tech debt: stability of irmaclient.Client.jobs mechanism #366

ivard opened this issue Dec 13, 2023 · 0 comments

Comments

@ivard
Copy link
Member

ivard commented Dec 13, 2023

Related to #365

The client.jobs mechanism is used for updating revocation witnesses. This mechanism is not very stable, given the StartJobs() and PauseJobs() logic built to prevent certain tasks from running in parallel. This indicates a code smell due to the absence of locking on specific variables that require it.

Current issues with the jobs mechanism include:

  • Jobs are created in the scheduler from the configuration, indicating module coupling, which is undesirable.
  • If jobs are paused because a session is taking place, the jobs queue grows. This results in the same task being executed multiple times in succession.
  • The logic for scheduling revocation jobs is complicated. It involves probability calculations, and the higher the probability, the more frequent the updates. We should consider to simplify this mechanism.

Note:

  • Consider delays caused by the update mechanism when doing an IRMA session. Ensure the user understands what is happening (UX impact) to avoid unclear waiting times.
  • For issuers/verifiers, there is an expectation that, for specific use cases, a revoked credential becomes almost immediately unusable
@ivard ivard changed the title Tech dept: stability of irmaclient.Client.jobs mechanism Tech debt: stability of irmaclient.Client.jobs mechanism Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant