Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

MPT: Connect Witness generation to zkEVM circuits #811

Open
aguzmant103 opened this issue Sep 28, 2022 · 2 comments
Open

MPT: Connect Witness generation to zkEVM circuits #811

aguzmant103 opened this issue Sep 28, 2022 · 2 comments
Assignees
Milestone

Comments

@aguzmant103
Copy link
Member

aguzmant103 commented Sep 28, 2022

Depends: #740 and #812

Description:

Another task:

@ed255
Copy link
Member

ed255 commented May 2, 2023

Here are some details of this task taken from an old issue. In particular, the MPT witness generation needs to be integrated into the Circuit Input Builder, more or less like this:

  1. Merge results from all account and storage accesses that happen in a block, and combine their MPT proofs into a Partial State Trie to generate proofs for the circuit.

@ed255
Copy link
Member

ed255 commented Jun 1, 2023

Related to #812

@ed255 ed255 added this to the MPT milestone Jun 29, 2023
GopherJ pushed a commit to dompute/zkevm-circuits that referenced this issue Sep 13, 2023
…alid Inputs" and "Insufficient Gas" (privacy-scaling-explorations#811)

* wip: preliminary work (EcAdd)

* wip: refactoring ecc circuit and ecaddop

* wip: prelim work for EcMul

* wip: ecmul decompose and more tests

* wip: some more changes in EcAdd and EcMul gadgets (evm cir)

* fix: refactor is_zero to avoid enforce < p

* chore: add back traces

* chore: update cargo lock

* chore: refactor AND to AND many

* wip: ecpairing in ecc ciruit

* fix: ecpairing ecc circuit debugged

* feat: invalid len(input) handling in ecpairing gadget

* assignment to ecpairing cells, tests OK

* is_valid todo complete

* minor refactor

* add invalid test for ec add

* chore: clippy fix

* fix: precompile failed (ecXX) through individual gadgets

* Feat: enforce gas_cost for precompiles called with invalid inputs (privacy-scaling-explorations#827)

* enforce gas_cost for ec_add

* enforce gas_cost for ec_mul

* enforce gas_cost for ec_pairing

* fix: test case generation random G2 coeffs

* chore: refactor unnecessary cell being returned

* enforce gas_cost for modexp

* remove tests for gadget that wont be used

* tests: invalid cases for ecpairing

* fix: input cells (pairing) for RLC

---------

Co-authored-by: Rohit Narurkar <[email protected]>

* gas costs for ecrecover and identity

* chore: fmt fix

* upgrade halo2-lib

* variadic size tests with valid/invalid inputs

---------

Co-authored-by: kunxian xia <[email protected]>
Co-authored-by: Zhang Zhuo <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants