This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
State Circuit Tracker #568
Labels
crate-zkevm-circuits
Issues related to the zkevm-circuits workspace member
Comments
48 tasks
9 tasks
ed255
added
the
crate-zkevm-circuits
5 tasks
12 tasks
jonathanpwang
pushed a commit
to axiom-crypto/zkevm-circuits
that referenced
this issue
Aug 1, 2023
* impl in the clear * implement PI aggregation in circuit * fix clippy * clean up * [fix] supports multiple rounds per hash for PI aggregation circuit * [chore] fix clippy * impl SubCircuit for MultiBatchCircuit * [refactor] pi aggregation circuit * [chore] cargo fmt * [feat] implement Aggregator * [feat] scripts for tests * [fix] figure * [chore] clean up; fix clippy; fix cargo fmt * [fix] remove env log for tests * [chore] partial address comments * fix some audit issues (privacy-scaling-explorations#512) * fix some audit issues * fix create rw * fix create rw * TOB-SCROLL-5: additional assertions (privacy-scaling-explorations#524) Co-authored-by: Aurélien Nicolas <[email protected]> --------- Co-authored-by: naure <[email protected]> Co-authored-by: Aurélien Nicolas <[email protected]> * [chore] update cargo lock * [chore] partial address comments * [doc] update readme for aggregator * [fix] fix test configs and clean up * [chore] clean up * [chore] update cargo toml * cargo fmt * [chore] sync up with halo2-lib dev branch * [chore] update cargo lock * [fix] chain id u32 -> u64 * [fix] chain id len for tests * [fix] typo in scripts * lint * a few comments on proof aggregation circuit (privacy-scaling-explorations#558) * a few comments inside core function for proof compression: extract_accumulators_and_proof * comments on proof compression circuit * comments on pi aggregation circuit, especially calculation of hash indexes when using Keccak circuit, which are hard-coded here so needs be very careful * comments on proof aggregation circuit * a few comments inside core function for proof compression: extract_accumulators_and_proof * comments on proof compression circuit * comments on pi aggregation circuit, especially calculation of hash indexes when using Keccak circuit, which are hard-coded here so needs be very careful * comments on proof aggregation circuit * clean up all commits from my side * clean up of all commits on my side * [feat] parameterize hard coded constants * [fix] compiling after merge * [refactor] remove pi agg circuit; integrated into proof agg circuit * [fix] chain id to_be_bytes * [feat] mock aggregation * wip * [fix] pi length in agg circuit * [refactor] optimize tests * [fix] compiling error * [fix] parameters for tests * [refactor] remove aggregation circuit * [fix] clippy * [fix] tests * [fix] address comments * [fix] remove unwrap for non-testing code * [fix] tests * address comments * [fix] address comments --------- Co-authored-by: Zhang Zhuo <[email protected]> Co-authored-by: naure <[email protected]> Co-authored-by: Aurélien Nicolas <[email protected]> Co-authored-by: Wenqing Hu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
BinaryNumberChip for simplifying code and lowering degree
General constraints
rw table: add committed_value to Rw::Account #557decided not to do this.Implement constraints for individual RwTableTags
Nice to haves
The text was updated successfully, but these errors were encountered: