You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the seedNucleus function located in applications/_nucleating_precipitates_MgRE/equations.h, there seems to be a discrepancy related to the usage of the weightedDistanceFromNucleusCenter method. The function requires the nucleus_rot_matrix, calculated by get_nucleus_rotation_matrix, as a parameter. However, the original weightedDistanceFromNucleusCenter method does not require this rotation matrix as a parameter. Instead, the rotation matrix is directly used in the method through shortest_edist_tensor = userInputs.get_nucleus_rotation_matrix(var_index) * shortest_edist_tensor.
As a result, compiling this app as it stands might result in an error due to this inconsistency. Should I consider removing the nucleus_rot_matrix input parameter from the seedNucleus function to align it with the weightedDistanceFromNucleusCenter method's logic ?
The text was updated successfully, but these errors were encountered:
On Tue, Dec 12, 2023, 8:58 AM zzzmx_josh ***@***.***> wrote:
In the seedNucleus function located in
applications/_nucleating_precipitates_MgRE/equations.h, there seems to be
a discrepancy related to the usage of the
weightedDistanceFromNucleusCenter method. The function requires the
nucleus_rot_matrix, calculated by get_nucleus_rotation_matrix, as a
parameter. However, the original weightedDistanceFromNucleusCenter method
does not require this rotation matrix as a parameter. Instead, the rotation
matrix is directly used in the method through shortest_edist_tensor =
userInputs.get_nucleus_rotation_matrix(var_index) * shortest_edist_tensor.
As a result, compiling this app as it stands might result in an error due
to this inconsistency. Should I consider removing the nucleus_rot_matrix
input parameter from the seedNucleus function to align it with the
weightedDistanceFromNucleusCenter method's logic ?
—
Reply to this email directly, view it on GitHub
<#200>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3FA46PYJTNKO5XOY6MKITYJBPITAVCNFSM6AAAAABARQS4MCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTOOBRGU4DINQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
In the
seedNucleus
function located inapplications/_nucleating_precipitates_MgRE/equations.h
, there seems to be a discrepancy related to the usage of theweightedDistanceFromNucleusCenter
method. The function requires thenucleus_rot_matrix
, calculated byget_nucleus_rotation_matrix
, as a parameter. However, the originalweightedDistanceFromNucleusCenter
method does not require this rotation matrix as a parameter. Instead, the rotation matrix is directly used in the method throughshortest_edist_tensor = userInputs.get_nucleus_rotation_matrix(var_index) * shortest_edist_tensor
.As a result, compiling this app as it stands might result in an error due to this inconsistency. Should I consider removing the
nucleus_rot_matrix
input parameter from theseedNucleus
function to align it with theweightedDistanceFromNucleusCenter
method's logic ?The text was updated successfully, but these errors were encountered: