-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DA] Planetscale engine tests: multi schema #4470
Comments
The Hence, PlanetScale is excluded from these tests because of a limitation of our implementation on its underlying Quaint+PSL connector. You may have noticed that the header of the // "multiSchema migrations and introspection are not implemented on MySQL yet"
#[test_suite(
capabilities(MultiSchema),
exclude(Mysql, Vitess("planetscale.js", "planetscale.js.wasm"))
)] For a more appropriate clarity to developers touching these tests, we'd only need to declare that the - // "multiSchema migrations and introspection are not implemented on MySQL yet"
#[test_suite(
capabilities(MultiSchema),
- exclude(Mysql, Vitess("planetscale.js", "planetscale.js.wasm"))
)] Unfortunately, this will only be possible once we understand the impact of removing these lines: prisma-engines/psl/psl-core/src/builtin_connectors/mysql_datamodel_connector.rs Lines 53 to 55 in ca42e86
|
For our users PlanetScale is just MySQL. So if we support |
I'd agree with you in theory, but we do NOT support In other words, it's totally normal for PlanetScale to fail on |
Why do we run the tests for it then? We do not have equivalent failing tests on the Rust side. |
We have equivalent tests on the Rust side which would fail, were they toggled off (or, so to speak, "commented out"). With this message above in mind, we see that the #[test_suite(
capabilities(MultiSchema),
exclude(Mysql, Vitess("planetscale.js", "planetscale.js.wasm"))
)] In plain English, this translates to:
A reasonable question/doubt would be:
That's correct. However, for some reason, MySQL is marked with the The immediate choice, in my opinion, is to get rid of this line, so that we can transform the test header from // "multiSchema migrations and introspection are not implemented on MySQL yet"
#[test_suite(
capabilities(MultiSchema),
exclude(Mysql, Vitess("planetscale.js", "planetscale.js.wasm"))
)] to - // "multiSchema migrations and introspection are not implemented on MySQL yet"
#[test_suite(
capabilities(MultiSchema),
- exclude(Mysql, Vitess("planetscale.js", "planetscale.js.wasm"))
)] |
This is a subcluster of failures after having enabled planetscale tests in #4423
Failing tests in this cluster:
Follow the process in This notion scratchpad page
The text was updated successfully, but these errors were encountered: