Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to @primer/[email protected] and @primer/[email protected] #2634

Merged
merged 12 commits into from
Jun 3, 2024
Merged

Upgrade to @primer/[email protected] and @primer/[email protected] #2634

merged 12 commits into from
Jun 3, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jun 3, 2024 •
edited
Loading

What are you trying to accomplish?

This is an intermediate step to #2607

This unblocks us by upgrading @primer/primitives and @primer/stylelint-config to the latest versions. And makes any migrations that are necessary for those upgrades.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d0b1720

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 15:41 Inactive
@jonrohan jonrohan changed the title Upgrade primitives change theme imports Upgrade to @primer/[email protected] and @primer/[email protected] Jun 3, 2024
@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 16:17 Inactive
@jonrohan jonrohan marked this pull request as ready for review June 3, 2024 16:21
@jonrohan jonrohan requested review from a team as code owners June 3, 2024 16:21
@jonrohan jonrohan requested a review from langermank June 3, 2024 16:21
@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 16:22 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 16:24 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 16:45 Inactive
@jonrohan jonrohan requested a review from langermank June 3, 2024 16:52
@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 19:51 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 3, 2024 19:56 Inactive
@jonrohan jonrohan merged commit af3ab76 into main Jun 3, 2024
12 checks passed
@jonrohan jonrohan deleted the upgrade_primitives_change_theme_imports branch June 3, 2024 19:57
@primer primer bot mentioned this pull request Jun 3, 2024
Merged
@camertron camertron mentioned this pull request Jun 20, 2024
Merged
1 task
@jonrohan jonrohan mentioned this pull request Jul 8, 2024
Merged
1 task
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@sennhann29 sennhann29 mentioned this pull request Sep 6, 2024
Open
@organich organich mentioned this pull request Sep 13, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 13, 2024
Open
@organich organich mentioned this pull request Sep 15, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 15, 2024
Open
@organich organich mentioned this pull request Sep 16, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 17, 2024
Open
@organich organich mentioned this pull request Sep 17, 2024
Open
@KaliforniaShell KaliforniaShell mentioned this pull request Oct 2, 2024
Merged
@InfiniteLove2020 InfiniteLove2020 mentioned this pull request Oct 3, 2024
Open
@Jekyle9444 Jekyle9444 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @langermank