Removes requirement of RigidBody2D #78 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an interesting one. The Rigidbody2D most definitely doesn't need to be required anymore and certainly not stored in an instance variable. That being said, it is very important for getting trigger callbacks. Either the triggers or the CharacterController2D need to have one. I am not sure what the best way to handle that is. Maybe documenting it in the README so that folks that don't know Unity well understand they need to have a Rigidbody2D on either the CC2D or their other triggers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes requirement of RigidBody2D as is no longer being used by the character controller.