diff --git a/docs/pull_request_template.md b/docs/pull_request_template.md new file mode 100644 index 00000000..77334558 --- /dev/null +++ b/docs/pull_request_template.md @@ -0,0 +1,34 @@ +## ๐Ÿ“Œ ๊ฐœ๋ฐœ ๋‚ด์šฉ + +์ˆ˜์ • or ์ถ”๊ฐ€, ๊ฐœ๋ฐœ๋œ ๋‚ด์šฉ์— ๋Œ€ํ•ด์„œ ๋ช…ํ™•ํ•˜๊ฒŒ ์ž‘์„ฑ๋ฐ”๋ž๋‹ˆ๋‹ค. + +## ๐Ÿ“‘ PR ํฌ์ธํŠธ + +์ข€ ๋” ์ƒ์„ธํ•˜๊ฒŒ ๋ฆฌ๋ทฐ ๋ฐ›๊ณ  ์‹ถ์€ ๋ถ€๋ถ„์„ ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”. + +
+ +### ๐Ÿ‘ฅ ํ˜‘์—…์„ ์œ„ํ•œ ์ฝ”๋“œ๋ฆฌ๋ทฐ + +1. ์„ธ์ƒ์— ๋ฐ”๋ณด๊ฐ™์€ ์งˆ๋ฌธ์€ ์—†๋‹ค. +2. ์‹ค์ˆ˜๋ฅผ ์˜ˆ๋ฐฉํ•˜๋Š” ํŒ€์ด ์•„๋‹ˆ๋ผ, ์‹ค์ˆ˜๋ฅผ ์ž˜ ๋‹ค๋ฃจ๋Š” ํŒ€์ด ๋˜์ž. +3. ๋ถ„์—…์ด ์•„๋‹Œ ํ˜‘์—…์„ ํ•˜์ž. ์šฐ๋ฆฐ ๋ชจ๋‘ ๊ฐ™์€ ๋ฌธ์ œ๋ฅผ ์ด๊ฒจ๋‚ด๊ธฐ ์œ„ํ•ด ๋ชจ์˜€๋‹ค. +4. ์˜์›ํ•œ ๊ฒƒ์€ ์—†์œผ๋‹ˆ ๋Œ€ํ™”๋ฅผ ํ•˜์ž. +5. ์„œ๋กœ ์กด์ค‘ํ•˜์ž. +6. ๋งŽ์ด ๋ถ€๋”ช์น˜๊ณ  ๊นจ๋‹ซ๊ณ  ๋ฐฐ์šฐ์ž. +7. ๋ถ€๋“œ๋Ÿฝ๊ฒŒ ์„ค๋“ํ•˜๊ณ  ์—ด๋ฆฐ ๋งˆ์Œ์œผ๋กœ ์„ค๋“๋‹นํ•ด๋ณด์ž. + +### โœ… ๋ฆฌ๋งˆ์ธ๋” + +- ๋ณธ์ธ์˜ ๋กœ์ปฌ์—์„œ ์ •์ƒ ๋™์ž‘ํ•˜๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”. +- ์ตœ์‹  ๋ธŒ๋žœ์น˜๋ฅผ Pull ๋ฐ›๊ณ  PR์„ ์š”์ฒญํ–ˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”. +- API๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ์„ ๊ฒฝ์šฐ ํ…Œ์ŠคํŠธ๋ฅผ ํ•˜๊ณ  PR์„ ์˜ฌ๋ ค์ฃผ์„ธ์š”. +- Conflict๊ฐ€ ๋‚ฌ์„ ๋•Œ, UI์ƒ์—์„œ ํ•ด๊ฒฐํ•˜์ง€ ๋ง๊ณ , ๋ณธ์ธ local์—์„œ ํ•ด๊ฒฐํ•ด์ฃผ์„ธ์š”. +- Commit ๋ฉ”์‹œ์ง€ ์ œ๋Œ€๋กœ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”. + +### โš™๏ธ ์ฝ”๋“œ๋ฆฌ๋ทฐ ๋ฃฐ + +- R(Request Change): ํ•ด๋‹น ๋ธ”๋Ÿญ์€ ๊ผญ ๋ณ€๊ฒฝํ•ด์ฃผ์…จ์œผ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค. +- C(Comment): ์›ฌ๋งŒํ•˜๋ฉด ๊ณ ๋ คํ•ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค. +- Q(Question) : ํ•ด๋‹น ๋ผ์ธ์ด ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค. +- A(Approve): ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค. ํ˜น์€ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค. diff --git a/module-internal/smtp-client/src/test/java/shop/jtoon/application/SmtpServiceTest.java b/module-internal/smtp-client/src/test/java/shop/jtoon/application/SmtpServiceTest.java index c49accfa..3ab5abb8 100644 --- a/module-internal/smtp-client/src/test/java/shop/jtoon/application/SmtpServiceTest.java +++ b/module-internal/smtp-client/src/test/java/shop/jtoon/application/SmtpServiceTest.java @@ -20,21 +20,6 @@ class SmtpServiceTest { @Mock JavaMailSenderImpl javaMailSender; - // @Test - // @DisplayName("SMTP ์—ฐ๊ฒฐ ์„ฑ๊ณต") - // void smtp_connection_success() { - // // when, then - // assertThatCode(() -> javaMailSender.testConnection()).doesNotThrowAnyException(); - // } - // - // @Test - // @DisplayName("SMTP ์—ฐ๊ฒฐ ์‹คํŒจ") - // void smtp_connection_fail() throws MessagingException { - // // when, then - // JavaMailSenderImpl emptyJavaMailSender = new JavaMailSenderImpl(); - // assertThatThrownBy(emptyJavaMailSender::testConnection).isInstanceOf(MessagingException.class); - // } - @Test @DisplayName("์ธ์ฆ Mail ์ƒ์„ฑ ์„ฑ๊ณต") void create_authentication_mail_success() {