Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make -jX not working with LeafGreen #600

Open
Nachtfrische opened this issue Jan 28, 2023 · 5 comments
Open

make -jX not working with LeafGreen #600

Nachtfrische opened this issue Jan 28, 2023 · 5 comments

Comments

@Nachtfrische
Copy link

Nachtfrische commented Jan 28, 2023

When using the -j parameter with "make leafgreen", I'm getting the following make warning about it using -j1.
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.

grafik

This does not appear when just using "make -j16" for FireRed. Therefore, building LeafGreen is way slower.

@Meister-anon
Copy link

Meister-anon commented Jan 28, 2023

Is it possible you're using a older repo, I just used that command and it built without problem?
or maybe there is some more recent issue, my fork is a month old.

edit: I even built twice to make sure it was actually using the faster speed,
and it was indeed far faster than just -j1. so its working as it should for me.

@Meister-anon
Copy link

Screenshot (2715) - Copy

@Nachtfrische
Copy link
Author

Nachtfrische commented Jan 28, 2023

I've cloned the repo four days ago, I had the same issue back then. Could perhaps be a regression on the newer versions.
I'm also using WSL2, not sure if that is related though.

It works for FireRed, not LeafGreen though.

grafik

@Acimut
Copy link
Contributor

Acimut commented Feb 1, 2023

I did a test build of pokefirered using time make compare_firered -j6 between Ubuntu 22.04 and 20.04. In the first one I got the error that I mention here, while in the second one it didn't, as you can see in the video that I leave you below (5:16).
https://www.youtube.com/watch?v=c-9Kt1FcUH0

You can also see that the build on Ubuntu 20.04 was faster (20 seconds) vs Ubuntu 22.04 (29 seconds) due to the -j issue.

@Acimut
Copy link
Contributor

Acimut commented Feb 5, 2023

You can use -j$NPROC instead of -jX using the full capacity of the CPU and it will not give any problems. It's not a definitive solution, but it's something. Checked on WSL2 Ubuntu 22.04 with time make compare_firered -j$NPROC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants