Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSH password to Supfile #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SSH password to Supfile #104

wants to merge 1 commit into from

Conversation

ffscl
Copy link

@ffscl ffscl commented Nov 28, 2016

A basic implementation of password based ssh authentication - I've been using this tool for a while, and it's great. We have some environments that we can't use key-based authentication.

I know in issue #29 there were some concerns raised. I think we need to let the end users decide to secure their Supfiles if they decide to place plaintext passwords in them.

@VojtechVitek
Copy link
Collaborator

Thanks for the PR!

This is interesting approach, but I wonder if people would really like to store their credentials into the Supfile itself, which is usually committed somewhere in a git repository.

Check out #107 (comment) for another approach, where you'd be asked for password on-the-fly.

@ffscl
Copy link
Author

ffscl commented Jan 18, 2017

Thanks @VojtechVitek - we're looking at using this for local Supfiles, not committing to git/sharing. As mentioned in my PR - I believe end users should decide how to secure their Supfiles. This is a simple option that is useful for individuals in environments where ssh keys aren't allowed.

I will wait for #107 if you decide not to merge. :)

@VojtechVitek
Copy link
Collaborator

VojtechVitek commented Jan 16, 2018

Thank you for the contribution, but I lean towards #107. I don't want Supfiles to be vulnerable by design.

What about the community, what do you guys think?

If there's enough interest, we could potentially use unsecure_password field (to clearly indicate this is a bad idea), but I'd prefer if we didn't. I'll leave this PR open for a bit for discussion.

@VojtechVitek VojtechVitek changed the title Add extra ssh auth method Add SSH password to Supfile Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants