Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove fix-encoding-pragma hook? #1032

Open
mxr opened this issue Apr 2, 2024 · 3 comments · May be fixed by #1034
Open

Deprecate/remove fix-encoding-pragma hook? #1032

mxr opened this issue Apr 2, 2024 · 3 comments · May be fixed by #1034

Comments

@mxr
Copy link
Member

mxr commented Apr 2, 2024

Since py2 is long unsupported

@asottile
Copy link
Member

asottile commented Apr 2, 2024

I think yeah, or at least make the default behavior to remove it -- or perhaps recommend pyupgrade instead

@mxr
Copy link
Member Author

mxr commented Apr 2, 2024

Suggesting pyupgrade makes sense to me. So to be clear the hook would no-op and fire a DeprecationWarning which suggests pyupgrade?

@asottile
Copy link
Member

asottile commented Apr 2, 2024

probably a minor release which prints a warning to stderr and adding (deprecated) to the hook name

and then in 6 months a major which deletes it (autoupdate handles this nicely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants