Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IJCK R2C9 #26

Closed
bryanwweber opened this issue Sep 27, 2017 · 6 comments
Closed

IJCK R2C9 #26

bryanwweber opened this issue Sep 27, 2017 · 6 comments

Comments

@bryanwweber
Copy link
Member

A reference should not be a required mapping of an experimental dataset. If the intention is to
make the community to adopt the ChemKED file structure, it might be easier to do so if
experimentalists can use the structure internally as well, i.e. to read, store, and share non-
published internal data.

@bryanwweber
Copy link
Member Author

Ref: #3 (comment)

From Kyle:

I agree with the reviewer here—reference shouldn't be required. We already started discussing some related topics in pr-omethe-us/PyKED#69 and privately; my suggestion is that we drop it as a required field, but validate it as we do now if given. I've started an issue on that here: pr-omethe-us/PyKED#76

@bryanwweber
Copy link
Member Author

This is also related to pr-omethe-us/PyKED#39

@bryanwweber
Copy link
Member Author

In my opinion, we should keep the reference as required, since the only required subfields are authors and year, and users should be able to fill in those no matter what (and it may even help them keep track of which data is which). However, as we've discussed in pr-omethe-us/PyKED#39, I think being able to selectively disable aspects of the validation would be very valuable. I added a response to the reviewer that reflects this viewpoint, but please feel free to make changes!

bryanwweber added a commit that referenced this issue Sep 30, 2017
bryanwweber added a commit that referenced this issue Oct 1, 2017
Turns out the journal was also required, so make a note that we've
dropped that requirement. Also, fix the text where some optional fields
were specified as required.
@kyleniemeyer
Copy link
Member

I actually think we can remove some of the second paragraph of your response—now that only year and authors are required in reference, there is nothing to validate in there, so validation would just be of the units etc.

@bryanwweber
Copy link
Member Author

Ok I'll take a look

bryanwweber added a commit that referenced this issue Oct 8, 2017
@bryanwweber
Copy link
Member Author

LGTM now, feel free to close

kyleniemeyer added a commit that referenced this issue Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants