pppd: Add pap-secrets and chap-secrets options #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaukrt
changed the title
|
Letting a non-privileged user control authentication seems like a really bad idea. |
|
Added OPT_PRIV to both options. |
|
Still needs explanation (in the commit message) of why we want such fine-grained control, as opposed to, say, using the |
These options allow a user to specify paths to pap-secrets and chap-secrets files, which is necessary when running multiple instances of pppd that may use the same username but with different passwords (e.g. running multiple PPTP tunnels). Signed-off-by: Tomas Paukrt <[email protected]>
|
Added explanation to the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options allow a user to specify paths to pap-secrets and chap-secrets files.