pppd: constify log format strings. #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroonza
force-pushed
the
make-log-args-const
branch
from
0afe688
to
d24bd17
Compare
|
I pushed the fix whilst the tests were still running ... I suspect this confused the CI - how can I get it to rerun? |
|
@paulusmack, @enaess: Have you seen this PR? |
|
I re-ran the tests; it seems this commit is still not quite right. |
jkroonza
force-pushed
the
make-log-args-const
branch
from
d24bd17
to
37ef21d
Compare
Indeed. Issue with pppoe-discovery that shadows the log functions. |
Found when trying to do a simple dbglog(__FUNCTION__); Signed-off-by: Jaco Kroon <[email protected]>
jkroonza
force-pushed
the
make-log-args-const
branch
from
37ef21d
to
68b1cb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when trying to do a simple dbglog(FUNCTION);