Solaris platform no longer compiles pppd

[enaess]

Something happened to linking with openssl on SunOS. Multiple unresolved symbols

Undefined			first referenced
   symbol  			    in file
  HMAC                                pppd-peap.o
  ERR_clear_error                     pppd-eap-tls.o
  SSL_CTX_set_default_passwd_cb       pppd-eap-tls.o
  SSL_load_error_strings              pppd-tls.o
  EVP_PKEY_free                       pppd-eap-tls.o
  UI_get0_user_data                   pppd-eap-tls.o
  ENGINE_ctrl_cmd                     pppd-eap-tls.o
  UI_create_method                    pppd-eap-tls.o
  PEM_read_X509_CRL                   pppd-tls.o
  SSL_do_handshake                    pppd-peap.o
  X509_STORE_add_lookup               pppd-tls.o
  sk_value                            pppd-eap-tls.o
  ENGINE_ctrl_cmd_string              pppd-eap-tls.o
  X509_NAME_oneline                   pppd-eap-tls.o
  SSL_state                           pppd-eap.o
  SSL_write                           pppd-peap.o
  X509_NAME_get_text_by_NID           pppd-tls.o
  EVP_CIPHER_CTX_new                  ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
  NCONF_free                          pppd-eap-tls.o
  NCONF_load                          pppd-eap-tls.o
  SSL_get_error                       pppd-peap.o
  ENGINE_free                         pppd-eap-tls.o
  BIO_ctrl_pending                    pppd-peap.o
  PKCS12_parse                        pppd-eap-tls.o
...

[enaess]

Not sure if this is the CI/CD pipeline job on SunOS that itself got an update to OpenSSL that causes it not to load, or the build somehow got changed to omit proper linker statements..

[paulusmack]

@carlsonj any insight?

[Neustradamus]

@RICCIARDI-Adrien: @enaess has done a ticket here about Solaris...

[RICCIARDI-Adrien]

I made several tests to try to find a previous version of the Solaris CI that works, but with no success.
It seems to me that some change in the GitHub macOS CI images broke the Solaris GitHub action. Even the maintainer of this action seems to be stuck finding a fix for now (vmactions/solaris-vm#36).

I suggest to disable the Solaris CI until its action is working again.

[RICCIARDI-Adrien]

The Solaris Action fix is still in progress, I keep you posted as soon as the maintainer releases a working version.
He could fix the FreeBSD Action, so Solaris fix might be close.

[RICCIARDI-Adrien]

With the latest Solaris CI PR (#464) I get the same link error than told in the first comment of this issue : https://github.com/ppp-project/ppp/actions/runs/7085423446/job/19281618388#step:3:2274.
I think that the Solaris CI is now working but there is a link error in PPP.

[Neustradamus]

@paulusmack, @carlsonj, @enaess: Can you look the error?

Paul, please merge the @RICCIARDI-Adrien PR to fix Solaris CI:

• CI: Fixed the Solaris build. #464

[RICCIARDI-Adrien]

Below is the full log of the failing build :

2023-12-06T09:31:41.6316514Z perl: warning: Setting locale failed.
2023-12-06T09:31:41.6317410Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:41.6318120Z 	LC_ALL = (unset),
2023-12-06T09:31:41.6360852Z 	LANG = "C.UTF-8"
2023-12-06T09:31:41.6361449Z     are supported and installed on your system.
2023-12-06T09:31:41.6362279Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:42.8902726Z perl: warning: Setting locale failed.
2023-12-06T09:31:42.8903626Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:42.8904442Z 	LC_ALL = (unset),
2023-12-06T09:31:42.8905158Z 	LANG = "C.UTF-8"
2023-12-06T09:31:42.8905512Z     are supported and installed on your system.
2023-12-06T09:31:42.8905985Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:43.1844603Z perl: warning: Setting locale failed.
2023-12-06T09:31:43.1845352Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:43.1846009Z 	LC_ALL = (unset),
2023-12-06T09:31:43.1846610Z 	LANG = "C.UTF-8"
2023-12-06T09:31:43.1847069Z     are supported and installed on your system.
2023-12-06T09:31:43.1847806Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:43.7575773Z perl: warning: Setting locale failed.
2023-12-06T09:31:43.7576582Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:43.7577239Z 	LC_ALL = (unset),
2023-12-06T09:31:43.7577849Z 	LANG = "C.UTF-8"
2023-12-06T09:31:43.7578314Z     are supported and installed on your system.
2023-12-06T09:31:43.7579000Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:44.7628969Z libtoolize: putting auxiliary files in '.'.
2023-12-06T09:31:44.7630245Z libtoolize: linking file './ltmain.sh'
2023-12-06T09:31:44.8066827Z libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
2023-12-06T09:31:44.8067489Z libtoolize: linking file 'm4/libtool.m4'
2023-12-06T09:31:44.8650933Z libtoolize: linking file 'm4/ltoptions.m4'
2023-12-06T09:31:44.9244808Z libtoolize: linking file 'm4/ltsugar.m4'
2023-12-06T09:31:44.9840036Z libtoolize: linking file 'm4/ltversion.m4'
2023-12-06T09:31:45.0429380Z libtoolize: linking file 'm4/lt~obsolete.m4'
2023-12-06T09:31:45.1145370Z perl: warning: Setting locale failed.
2023-12-06T09:31:45.1146310Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:45.1146963Z 	LC_ALL = (unset),
2023-12-06T09:31:45.1147623Z 	LANG = "C.UTF-8"
2023-12-06T09:31:45.1147934Z     are supported and installed on your system.
2023-12-06T09:31:45.1148391Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:45.4095716Z perl: warning: Setting locale failed.
2023-12-06T09:31:45.4096465Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:45.4097103Z 	LC_ALL = (unset),
2023-12-06T09:31:45.4097743Z 	LANG = "C.UTF-8"
2023-12-06T09:31:45.4098203Z     are supported and installed on your system.
2023-12-06T09:31:45.4098656Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:46.0080465Z perl: warning: Setting locale failed.
2023-12-06T09:31:46.0081342Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:46.0081972Z 	LC_ALL = (unset),
2023-12-06T09:31:46.0082600Z 	LANG = "C.UTF-8"
2023-12-06T09:31:46.0083089Z     are supported and installed on your system.
2023-12-06T09:31:46.0084442Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:46.8654602Z perl: warning: Setting locale failed.
2023-12-06T09:31:46.8655409Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:46.8656058Z 	LC_ALL = (unset),
2023-12-06T09:31:46.8656695Z 	LANG = "C.UTF-8"
2023-12-06T09:31:46.8657165Z     are supported and installed on your system.
2023-12-06T09:31:46.8657883Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:46.9265545Z perl: warning: Setting locale failed.
2023-12-06T09:31:46.9266474Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:46.9267269Z 	LC_ALL = (unset),
2023-12-06T09:31:46.9267971Z 	LANG = "C.UTF-8"
2023-12-06T09:31:46.9268548Z     are supported and installed on your system.
2023-12-06T09:31:46.9269456Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:47.0667825Z perl: warning: Setting locale failed.
2023-12-06T09:31:47.0668972Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:47.0669776Z 	LC_ALL = (unset),
2023-12-06T09:31:47.0670585Z 	LANG = "C.UTF-8"
2023-12-06T09:31:47.0670970Z     are supported and installed on your system.
2023-12-06T09:31:47.0671576Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:47.0777994Z perl: warning: Setting locale failed.
2023-12-06T09:31:47.0780608Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:47.0781324Z 	LC_ALL = (unset),
2023-12-06T09:31:47.0781836Z 	LANG = "C.UTF-8"
2023-12-06T09:31:47.0782326Z     are supported and installed on your system.
2023-12-06T09:31:47.0782978Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:47.6969806Z configure.ac:18: installing './compile'
2023-12-06T09:31:47.6970657Z configure.ac:22: installing './config.guess'
2023-12-06T09:31:47.6971403Z configure.ac:22: installing './config.sub'
2023-12-06T09:31:47.6972079Z configure.ac:9: installing './install-sh'
2023-12-06T09:31:47.6975598Z configure.ac:9: installing './missing'
2023-12-06T09:31:47.7058434Z Makefile.am: installing './INSTALL'
2023-12-06T09:31:47.7409885Z chat/Makefile.am: installing './depcomp'
2023-12-06T09:31:47.9915625Z parallel-tests: installing './test-driver'
2023-12-06T09:31:48.3044805Z perl: warning: Setting locale failed.
2023-12-06T09:31:48.3046702Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:48.3047406Z 	LC_ALL = (unset),
2023-12-06T09:31:48.3048082Z 	LANG = "C.UTF-8"
2023-12-06T09:31:48.3048593Z     are supported and installed on your system.
2023-12-06T09:31:48.3049382Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:49.5393702Z perl: warning: Setting locale failed.
2023-12-06T09:31:49.5394589Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:49.5395085Z 	LC_ALL = (unset),
2023-12-06T09:31:49.5395604Z 	LANG = "C.UTF-8"
2023-12-06T09:31:49.5395959Z     are supported and installed on your system.
2023-12-06T09:31:49.5396555Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:49.8324581Z perl: warning: Setting locale failed.
2023-12-06T09:31:49.8325455Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:49.8326167Z 	LC_ALL = (unset),
2023-12-06T09:31:49.8326834Z 	LANG = "C.UTF-8"
2023-12-06T09:31:49.8327337Z     are supported and installed on your system.
2023-12-06T09:31:49.8328160Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:50.4294520Z perl: warning: Setting locale failed.
2023-12-06T09:31:50.4295373Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:50.4296082Z 	LC_ALL = (unset),
2023-12-06T09:31:50.4296735Z 	LANG = "C.UTF-8"
2023-12-06T09:31:50.4297232Z     are supported and installed on your system.
2023-12-06T09:31:50.4298005Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:51.1076313Z perl: warning: Setting locale failed.
2023-12-06T09:31:51.1076881Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:51.1077682Z 	LC_ALL = (unset),
2023-12-06T09:31:51.1078121Z 	LANG = "C.UTF-8"
2023-12-06T09:31:51.1078426Z     are supported and installed on your system.
2023-12-06T09:31:51.1078883Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:51.1679671Z perl: warning: Setting locale failed.
2023-12-06T09:31:51.1680826Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:51.1681358Z 	LC_ALL = (unset),
2023-12-06T09:31:51.1682173Z 	LANG = "C.UTF-8"
2023-12-06T09:31:51.1682545Z     are supported and installed on your system.
2023-12-06T09:31:51.1683108Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:51.3007432Z perl: warning: Setting locale failed.
2023-12-06T09:31:51.3008276Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:51.3008977Z 	LC_ALL = (unset),
2023-12-06T09:31:51.3009655Z 	LANG = "C.UTF-8"
2023-12-06T09:31:51.3010186Z     are supported and installed on your system.
2023-12-06T09:31:51.3011054Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:51.3121979Z perl: warning: Setting locale failed.
2023-12-06T09:31:51.3124244Z perl: warning: Please check that your locale settings:
2023-12-06T09:31:51.3124933Z 	LC_ALL = (unset),
2023-12-06T09:31:51.3125347Z 	LANG = "C.UTF-8"
2023-12-06T09:31:51.3125645Z     are supported and installed on your system.
2023-12-06T09:31:51.3126112Z perl: warning: Falling back to the standard locale ("C").
2023-12-06T09:31:52.5108125Z checking whether make supports nested variables... yes
2023-12-06T09:31:52.5212880Z checking for a BSD-compatible install... /usr/bin/ginstall -c
2023-12-06T09:31:52.5235848Z checking whether build environment is sane... yes
2023-12-06T09:31:52.5401401Z checking for a thread-safe mkdir -p... /usr/bin/gmkdir -p
2023-12-06T09:31:52.5410125Z checking for gawk... gawk
2023-12-06T09:31:52.5563029Z checking whether make sets $(MAKE)... yes
2023-12-06T09:31:52.5711190Z checking whether to enable maintainer-specific portions of Makefiles... yes
2023-12-06T09:31:52.5712577Z checking for gcc... gcc
2023-12-06T09:31:52.6947722Z checking whether the C compiler works... yes
2023-12-06T09:31:52.6949566Z checking for C compiler default output file name... a.out
2023-12-06T09:31:52.7507381Z checking for suffix of executables... 
2023-12-06T09:31:52.8121322Z checking whether we are cross compiling... no
2023-12-06T09:31:52.8478233Z checking for suffix of object files... o
2023-12-06T09:31:52.8783087Z checking whether we are using the GNU C compiler... yes
2023-12-06T09:31:52.9092115Z checking whether gcc accepts -g... yes
2023-12-06T09:31:52.9494934Z checking for gcc option to accept ISO C89... none needed
2023-12-06T09:31:53.0078456Z checking whether gcc understands -c and -o together... yes
2023-12-06T09:31:53.0179436Z checking for style of include used by make... GNU
2023-12-06T09:31:53.0761221Z checking dependency style of gcc... gcc3
2023-12-06T09:31:53.0765160Z checking whether ln -s works... yes
2023-12-06T09:31:53.1631947Z checking build system type... x86_64-pc-solaris2.11
2023-12-06T09:31:53.1636913Z checking host system type... x86_64-pc-solaris2.11
2023-12-06T09:31:53.1643775Z checking how to print strings... print -r
2023-12-06T09:31:53.2880924Z checking for a sed that does not truncate output... /usr/bin/gsed
2023-12-06T09:31:53.3156846Z checking for grep that handles long lines and -e... /usr/bin/ggrep
2023-12-06T09:31:53.3157837Z checking for egrep... /usr/bin/ggrep -E
2023-12-06T09:31:53.3158502Z checking for fgrep... /usr/bin/ggrep -F
2023-12-06T09:31:53.3199983Z checking for ld used by gcc... /usr/bin/ld
2023-12-06T09:31:53.3228208Z checking if the linker (/usr/bin/ld) is GNU ld... no
2023-12-06T09:31:53.3314260Z checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -p
2023-12-06T09:31:53.3656669Z checking the name lister (/usr/bin/nm -p) interface... BSD nm
2023-12-06T09:31:53.3717455Z checking the maximum length of command line arguments... 1572480
2023-12-06T09:31:53.3755843Z checking how to convert x86_64-pc-solaris2.11 file names to x86_64-pc-solaris2.11 format... func_convert_file_noop
2023-12-06T09:31:53.3758938Z checking how to convert x86_64-pc-solaris2.11 file names to toolchain format... func_convert_file_noop
2023-12-06T09:31:53.3764500Z checking for /usr/bin/ld option to reload object files... -r
2023-12-06T09:31:53.3771779Z checking for objdump... no
2023-12-06T09:31:53.3778303Z checking how to recognize dependent libraries... pass_all
2023-12-06T09:31:53.3784215Z checking for dlltool... no
2023-12-06T09:31:53.3789192Z checking how to associate runtime and link libraries... print -r --
2023-12-06T09:31:53.3795385Z checking for ar... ar
2023-12-06T09:31:53.4219722Z checking for archiver @FILE support... no
2023-12-06T09:31:53.4223425Z checking for strip... strip
2023-12-06T09:31:53.4230215Z checking for ranlib... ranlib
2023-12-06T09:31:53.5130539Z checking command to parse /usr/bin/nm -p output from gcc object... failed
2023-12-06T09:31:53.5164341Z checking for sysroot... no
2023-12-06T09:31:53.5262721Z checking for a working dd... /usr/bin/dd
2023-12-06T09:31:53.5343860Z checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
2023-12-06T09:31:53.5647153Z checking for mt... mt
2023-12-06T09:31:53.5719596Z checking if mt is a manifest tool... no
2023-12-06T09:31:53.6126909Z checking how to run the C preprocessor... gcc -E
2023-12-06T09:31:53.8137317Z checking for ANSI C header files... yes
2023-12-06T09:31:53.8507445Z checking for sys/types.h... yes
2023-12-06T09:31:53.8941554Z checking for sys/stat.h... yes
2023-12-06T09:31:53.9359006Z checking for stdlib.h... yes
2023-12-06T09:31:53.9779717Z checking for string.h... yes
2023-12-06T09:31:54.0225862Z checking for memory.h... yes
2023-12-06T09:31:54.0632429Z checking for strings.h... yes
2023-12-06T09:31:54.1060511Z checking for inttypes.h... yes
2023-12-06T09:31:54.1489208Z checking for stdint.h... yes
2023-12-06T09:31:54.1922779Z checking for unistd.h... yes
2023-12-06T09:31:54.2347930Z checking for dlfcn.h... yes
2023-12-06T09:31:54.2430456Z checking for objdir... .libs
2023-12-06T09:31:54.3652093Z checking if gcc supports -fno-rtti -fno-exceptions... no
2023-12-06T09:31:54.3656331Z checking for gcc option to produce PIC... -fPIC -DPIC
2023-12-06T09:31:54.4034297Z checking if gcc PIC flag -fPIC -DPIC works... yes
2023-12-06T09:31:54.4385391Z checking if gcc static flag -static works... no
2023-12-06T09:31:54.4846458Z checking if gcc supports -c -o file.o... yes
2023-12-06T09:31:54.4855745Z checking if gcc supports -c -o file.o... (cached) yes
2023-12-06T09:31:54.4857156Z checking whether the gcc linker (/usr/bin/ld -64) supports shared libraries... yes
2023-12-06T09:31:54.5412133Z checking whether -lc should be explicitly linked in... no
2023-12-06T09:31:54.5607913Z checking dynamic linker characteristics... solaris2.11 ld.so
2023-12-06T09:31:54.5612381Z checking how to hardcode library paths into programs... immediate
2023-12-06T09:31:54.5662575Z checking whether stripping libraries is possible... no
2023-12-06T09:31:54.5665722Z checking if libtool supports shared libraries... yes
2023-12-06T09:31:54.5669665Z checking whether to build shared libraries... yes
2023-12-06T09:31:54.5673564Z checking whether to build static libraries... no
2023-12-06T09:31:54.5681686Z checking for pkg-config... no
2023-12-06T09:31:54.6058739Z checking for stdbool.h that conforms to C99... yes
2023-12-06T09:31:54.6793382Z checking for _Bool... yes
2023-12-06T09:31:54.7201838Z checking asm/types.h usability... no
2023-12-06T09:31:54.7459647Z checking asm/types.h presence... no
2023-12-06T09:31:54.7461110Z checking for asm/types.h... no
2023-12-06T09:31:54.7877127Z checking crypt.h usability... yes
2023-12-06T09:31:54.8079999Z checking crypt.h presence... yes
2023-12-06T09:31:54.8081396Z checking for crypt.h... yes
2023-12-06T09:31:54.8552075Z checking paths.h usability... yes
2023-12-06T09:31:54.8719362Z checking paths.h presence... yes
2023-12-06T09:31:54.8722636Z checking for paths.h... yes
2023-12-06T09:31:54.9152163Z checking shadow.h usability... yes
2023-12-06T09:31:54.9320022Z checking shadow.h presence... yes
2023-12-06T09:31:54.9321047Z checking for shadow.h... yes
2023-12-06T09:31:54.9749256Z checking stddef.h usability... yes
2023-12-06T09:31:54.9950727Z checking stddef.h presence... yes
2023-12-06T09:31:54.9951427Z checking for stddef.h... yes
2023-12-06T09:31:55.0320236Z checking stdarg.h usability... yes
2023-12-06T09:31:55.0482537Z checking stdarg.h presence... yes
2023-12-06T09:31:55.0486588Z checking for stdarg.h... yes
2023-12-06T09:31:55.1000819Z checking sys/dlpi.h usability... yes
2023-12-06T09:31:55.1201628Z checking sys/dlpi.h presence... yes
2023-12-06T09:31:55.1206192Z checking for sys/dlpi.h... yes
2023-12-06T09:31:55.1645069Z checking sys/ioctl.h usability... yes
2023-12-06T09:31:55.1803162Z checking sys/ioctl.h presence... yes
2023-12-06T09:31:55.1807645Z checking for sys/ioctl.h... yes
2023-12-06T09:31:55.2333172Z checking sys/socket.h usability... yes
2023-12-06T09:31:55.2556000Z checking sys/socket.h presence... yes
2023-12-06T09:31:55.2556727Z checking for sys/socket.h... yes
2023-12-06T09:31:55.2991813Z checking sys/time.h usability... yes
2023-12-06T09:31:55.3173695Z checking sys/time.h presence... yes
2023-12-06T09:31:55.3177741Z checking for sys/time.h... yes
2023-12-06T09:31:55.3621591Z checking sys/uio.h usability... yes
2023-12-06T09:31:55.3821977Z checking sys/uio.h presence... yes
2023-12-06T09:31:55.3823106Z checking for sys/uio.h... yes
2023-12-06T09:31:55.4276402Z checking time.h usability... yes
2023-12-06T09:31:55.4480095Z checking time.h presence... yes
2023-12-06T09:31:55.4481229Z checking for time.h... yes
2023-12-06T09:31:55.4588513Z checking for unistd.h... (cached) yes
2023-12-06T09:31:55.5049889Z checking utmp.h usability... yes
2023-12-06T09:31:55.5243957Z checking utmp.h presence... yes
2023-12-06T09:31:55.5248694Z checking for utmp.h... yes
2023-12-06T09:31:55.6058790Z checking size of unsigned int... 4
2023-12-06T09:31:55.6781140Z checking size of unsigned long... 8
2023-12-06T09:31:55.7507427Z checking size of unsigned short... 2
2023-12-06T09:31:55.8181464Z checking for mmap... yes
2023-12-06T09:31:55.8803814Z checking for logwtmp... no
2023-12-06T09:31:55.9438432Z checking for strerror... yes
2023-12-06T09:31:55.9976205Z checking for logwtmp in -lutil... no
2023-12-06T09:31:56.0566459Z checking for crypt in -lcrypt... yes
2023-12-06T09:31:56.0576479Z checking for pkg-config... no
2023-12-06T09:31:56.1744641Z checking whether compiling and linking against OpenSSL works... no
2023-12-06T09:31:56.1913753Z checking for md4 support in openssl... yes
2023-12-06T09:31:56.2064523Z checking for md5 support in openssl... yes
2023-12-06T09:31:56.2223841Z checking for des support in openssl... yes
2023-12-06T09:31:56.2383972Z checking for sha support in openssl... yes
2023-12-06T09:31:56.2690350Z checking if compiling and linking against libsrp works... no
2023-12-06T09:31:56.2988584Z checking if compiling and linking against libatm works... no
2023-12-06T09:31:56.3715177Z checking if compiling and linking against libpam works... yes
2023-12-06T09:31:56.4590238Z checking if compiling and linking against libpcap works... yes
2023-12-06T09:31:56.4611128Z configure: WARNING: Packet activity filter not supported on SunOS
2023-12-06T09:31:56.4856722Z checking that generated files are newer than configure... done
2023-12-06T09:31:56.4860388Z configure: creating ./config.status
2023-12-06T09:31:57.0595927Z config.status: creating Makefile
2023-12-06T09:31:57.0775402Z config.status: creating chat/Makefile
2023-12-06T09:31:57.1014981Z config.status: creating contrib/Makefile
2023-12-06T09:31:57.1248196Z config.status: creating contrib/pppgetpass/Makefile
2023-12-06T09:31:57.1492426Z config.status: creating common/Makefile
2023-12-06T09:31:57.1724774Z config.status: creating include/Makefile
2023-12-06T09:31:57.1977979Z config.status: creating modules/Makefile
2023-12-06T09:31:57.2212052Z config.status: creating pppd/Makefile
2023-12-06T09:31:57.2481830Z config.status: creating pppd/pppd.pc
2023-12-06T09:31:57.2721468Z config.status: creating pppd/plugins/Makefile
2023-12-06T09:31:57.2957423Z config.status: creating pppd/plugins/pppoe/Makefile
2023-12-06T09:31:57.3197113Z config.status: creating pppd/plugins/pppoatm/Makefile
2023-12-06T09:31:57.3430561Z config.status: creating pppd/plugins/pppol2tp/Makefile
2023-12-06T09:31:57.3669582Z config.status: creating pppd/plugins/radius/Makefile
2023-12-06T09:31:57.3910185Z config.status: creating pppdump/Makefile
2023-12-06T09:31:57.4176743Z config.status: creating pppstats/Makefile
2023-12-06T09:31:57.4421000Z config.status: creating scripts/Makefile
2023-12-06T09:31:57.4663100Z config.status: creating pppd/config.h
2023-12-06T09:31:57.4884442Z config.status: creating pppd/pppdconf.h
2023-12-06T09:31:57.5119367Z config.status: creating pppd/plugins/pppoe/config.h
2023-12-06T09:31:57.5358646Z config.status: executing depfiles commands
2023-12-06T09:31:58.0196346Z config.status: executing libtool commands
2023-12-06T09:31:58.0414800Z 
2023-12-06T09:31:58.0415275Z Setting up SunOS kernel module(s)
2023-12-06T09:31:58.0516174Z   Makedefs.com <= solaris/Makedefs.gcc
2023-12-06T09:31:58.0557488Z   solaris/Makefile <= solaris/Makefile.sol2gcc-64x
2023-12-06T09:31:58.0582015Z 
2023-12-06T09:31:58.0582430Z ppp version 2.5.1-dev
2023-12-06T09:31:58.0582926Z     Prefix...............: /usr/local
2023-12-06T09:31:58.0583474Z     Runtime Dir..........: /pppd
2023-12-06T09:31:58.0583958Z     Logfile Dir..........: ${prefix}/var/log/ppp
2023-12-06T09:31:58.0584478Z     Plugin Dir...........: ${exec_prefix}/lib/pppd/2.5.1-dev
2023-12-06T09:31:58.0584955Z     System CA Path ......: ${prefix}/etc/ssl/certs
2023-12-06T09:31:58.0585513Z     With OpenSSL.........: yes
2023-12-06T09:31:58.0586072Z     With libatm..........: no
2023-12-06T09:31:58.0586697Z     With libpam..........: yes
2023-12-06T09:31:58.0587231Z     With libpcap.........: no
2023-12-06T09:31:58.0587777Z     With libsrp..........: no
2023-12-06T09:31:58.0588651Z     C Compiler...........: gcc -Wno-deprecated-declarations -DSOL2 -DSRV4
2023-12-06T09:31:58.0589621Z     Linker...............: /usr/bin/ld -64  
2023-12-06T09:31:58.0590146Z 
2023-12-06T09:31:58.0590314Z Features enabled
2023-12-06T09:31:58.0590789Z     Microsoft Extensions.: yes
2023-12-06T09:31:58.0591354Z     Multilink............: no
2023-12-06T09:31:58.0591902Z     Plugins..............: yes
2023-12-06T09:31:58.0592455Z     CBCP.................: no
2023-12-06T09:31:58.0592990Z     IPV6CP...............: yes
2023-12-06T09:31:58.0593569Z     EAP-TLS..............: yes
2023-12-06T09:31:58.0594112Z     PEAP.................: yes
2023-12-06T09:31:58.0594609Z     systemd notifications: no
2023-12-06T09:31:58.0594974Z 
2023-12-06T09:31:58.0976809Z Making all in chat
2023-12-06T09:31:58.1057483Z   CC       chat-chat.o
2023-12-06T09:31:58.2236211Z   CCLD     chat
2023-12-06T09:31:58.3015336Z Making all in contrib
2023-12-06T09:31:58.3129572Z Making all in pppgetpass
2023-12-06T09:31:58.3209372Z   CC       pppgetpass_vt-pppgetpass.vt.o
2023-12-06T09:31:58.3768879Z   CCLD     pppgetpass.vt
2023-12-06T09:31:58.4619208Z Making all in pppd
2023-12-06T09:31:58.4845191Z make  all-am
2023-12-06T09:31:58.4973507Z   CC       libppp_crypto_la-crypto.lo
2023-12-06T09:31:58.5763074Z   CC       libppp_crypto_la-ppp-md5.lo
2023-12-06T09:31:58.6675656Z   CC       libppp_crypto_la-ppp-md4.lo
2023-12-06T09:31:58.7576873Z   CC       libppp_crypto_la-ppp-sha1.lo
2023-12-06T09:31:58.8486732Z   CC       libppp_crypto_la-ppp-des.lo
2023-12-06T09:31:58.9394839Z   CCLD     libppp_crypto.la
2023-12-06T09:31:59.0438369Z   CC       pppd-auth.o
2023-12-06T09:31:59.2122512Z   CC       pppd-ccp.o
2023-12-06T09:31:59.3144976Z   CC       pppd-chap-md5.o
2023-12-06T09:31:59.3648709Z   CC       pppd-chap.o
2023-12-06T09:31:59.4404938Z   CC       pppd-demand.o
2023-12-06T09:31:59.5034269Z   CC       pppd-eap.o
2023-12-06T09:31:59.6564003Z   CC       pppd-ecp.o
2023-12-06T09:31:59.7023886Z   CC       pppd-fsm.o
2023-12-06T09:31:59.7763659Z   CC       pppd-ipcp.o
2023-12-06T09:31:59.9154886Z   CC       pppd-lcp.o
2023-12-06T09:31:59.9502500Z lcp.c: In function 'lcp_rtt_update_buffer':
2023-12-06T09:31:59.9506074Z lcp.c:2310:15: warning: passing argument 1 of 'msync' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
2023-12-06T09:31:59.9507619Z      if (msync(lcp_rtt_buffer, LCP_RTT_FILE_SIZE, MS_ASYNC) < 0)
2023-12-06T09:31:59.9508430Z                ^~~~~~~~~~~~~~
2023-12-06T09:31:59.9510194Z In file included from lcp.c:54:0:
2023-12-06T09:31:59.9512200Z /usr/include/sys/mman.h:204:12: note: expected 'void *' but argument is of type 'volatile u_int32_t * {aka volatile unsigned int *}'
2023-12-06T09:31:59.9514209Z  extern int msync(void *, size_t, int);
2023-12-06T09:31:59.9515097Z             ^~~~~
2023-12-06T09:31:59.9518515Z lcp.c: In function 'lcp_rtt_open_file':
2023-12-06T09:31:59.9521040Z lcp.c:2444:9: warning: passing argument 1 of 'memset' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
2023-12-06T09:31:59.9522684Z   memset(lcp_rtt_buffer, 0, LCP_RTT_FILE_SIZE);
2023-12-06T09:31:59.9523522Z          ^~~~~~~~~~~~~~
2023-12-06T09:31:59.9524387Z In file included from /usr/include/string.h:12:0,
2023-12-06T09:31:59.9525043Z                  from lcp.c:48:
2023-12-06T09:31:59.9526358Z /usr/include/iso/string_iso.h:85:14: note: expected 'void *' but argument is of type 'volatile u_int32_t * {aka volatile unsigned int *}'
2023-12-06T09:31:59.9528205Z  extern void *memset(void *, int, size_t);
2023-12-06T09:31:59.9529137Z               ^~~~~~
2023-12-06T09:31:59.9529941Z lcp.c: In function 'lcp_rtt_close_file':
2023-12-06T09:31:59.9531398Z lcp.c:2460:16: warning: passing argument 1 of 'munmap' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]
2023-12-06T09:31:59.9532732Z      if (munmap(lcp_rtt_buffer, LCP_RTT_FILE_SIZE) < 0)
2023-12-06T09:31:59.9533497Z                 ^~~~~~~~~~~~~~
2023-12-06T09:31:59.9533992Z In file included from lcp.c:54:0:
2023-12-06T09:31:59.9535363Z /usr/include/sys/mman.h:202:12: note: expected 'void *' but argument is of type 'volatile u_int32_t * {aka volatile unsigned int *}'
2023-12-06T09:31:59.9536595Z  extern int munmap(void *, size_t);
2023-12-06T09:31:59.9537137Z             ^~~~~~
2023-12-06T09:32:00.0461985Z   CC       pppd-magic.o
2023-12-06T09:32:00.0926711Z   CC       pppd-main.o
2023-12-06T09:32:00.2150205Z   CC       pppd-options.o
2023-12-06T09:32:00.3245868Z   CC       pppd-session.o
2023-12-06T09:32:00.3522752Z session.c:167:5: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
2023-12-06T09:32:00.3523894Z      &conversation,
2023-12-06T09:32:00.3524278Z      ^
2023-12-06T09:32:00.3524961Z session.c:167:5: note: (near initialization for 'pam_conv_data.conv')
2023-12-06T09:32:00.3899363Z   CC       pppd-tty.o
2023-12-06T09:32:00.4961754Z   CC       pppd-upap.o
2023-12-06T09:32:00.5586221Z   CC       pppd-utils.o
2023-12-06T09:32:00.6482176Z   CC       pppd-sys-solaris.o
2023-12-06T09:32:00.7943468Z   CC       pppd-chap_ms.o
2023-12-06T09:32:00.8666534Z   CC       pppd-crypto_ms.o
2023-12-06T09:32:00.9058037Z   CC       pppd-mppe.o
2023-12-06T09:32:00.9604901Z   CC       pppd-ipv6cp.o
2023-12-06T09:32:01.0536326Z   CC       pppd-eui64.o
2023-12-06T09:32:01.0990076Z   CC       pppd-eap-tls.o
2023-12-06T09:32:01.2334174Z   CC       pppd-tls.o
2023-12-06T09:32:01.3355843Z   CC       pppd-peap.o
2023-12-06T09:32:01.4946233Z   CCLD     pppd
2023-12-06T09:32:01.5971918Z Undefined			first referenced
2023-12-06T09:32:01.5972910Z  symbol  			    in file
2023-12-06T09:32:01.5974232Z HMAC                                pppd-peap.o
2023-12-06T09:32:01.5978961Z ERR_clear_error                     pppd-eap-tls.o
2023-12-06T09:32:01.5980263Z SSL_CTX_set_default_passwd_cb       pppd-eap-tls.o
2023-12-06T09:32:01.5984885Z SSL_load_error_strings              pppd-tls.o
2023-12-06T09:32:01.5986027Z EVP_PKEY_free                       pppd-eap-tls.o
2023-12-06T09:32:01.5990676Z UI_get0_user_data                   pppd-eap-tls.o
2023-12-06T09:32:01.5991862Z ENGINE_ctrl_cmd                     pppd-eap-tls.o
2023-12-06T09:32:01.5997000Z UI_create_method                    pppd-eap-tls.o
2023-12-06T09:32:01.5998143Z PEM_read_X509_CRL                   pppd-tls.o
2023-12-06T09:32:01.6002939Z SSL_do_handshake                    pppd-peap.o
2023-12-06T09:32:01.6004071Z X509_STORE_add_lookup               pppd-tls.o
2023-12-06T09:32:01.6004827Z sk_value                            pppd-eap-tls.o
2023-12-06T09:32:01.6005597Z ENGINE_ctrl_cmd_string              pppd-eap-tls.o
2023-12-06T09:32:01.6007854Z X509_NAME_oneline                   pppd-eap-tls.o
2023-12-06T09:32:01.6008633Z SSL_state                           pppd-eap.o
2023-12-06T09:32:01.6009369Z SSL_write                           pppd-peap.o
2023-12-06T09:32:01.6011887Z X509_NAME_get_text_by_NID           pppd-tls.o
2023-12-06T09:32:01.6013219Z EVP_CIPHER_CTX_new                  ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6014378Z NCONF_free                          pppd-eap-tls.o
2023-12-06T09:32:01.6015313Z NCONF_load                          pppd-eap-tls.o
2023-12-06T09:32:01.6016258Z SSL_get_error                       pppd-peap.o
2023-12-06T09:32:01.6017188Z ENGINE_free                         pppd-eap-tls.o
2023-12-06T09:32:01.6018101Z BIO_ctrl_pending                    pppd-peap.o
2023-12-06T09:32:01.6019040Z PKCS12_parse                        pppd-eap-tls.o
2023-12-06T09:32:01.6019970Z PEM_read_X509                       pppd-tls.o
2023-12-06T09:32:01.6020631Z ERR_error_string                    pppd-tls.o
2023-12-06T09:32:01.6021118Z ENGINE_load_private_key             pppd-eap-tls.o
2023-12-06T09:32:01.6021572Z X509_free                           pppd-eap-tls.o
2023-12-06T09:32:01.6022000Z ERR_get_error                       pppd-tls.o
2023-12-06T09:32:01.6022410Z NCONF_new                           pppd-eap-tls.o
2023-12-06T09:32:01.6022838Z PKCS12_free                         pppd-eap-tls.o
2023-12-06T09:32:01.6023280Z PEM_read_bio_PrivateKey             pppd-eap-tls.o
2023-12-06T09:32:01.6023856Z EVP_MD_CTX_create                   ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.6024539Z EVP_MD_CTX_destroy                  ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.6025206Z EVP_CipherUpdate                    ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6025743Z X509_LOOKUP_hash_dir                pppd-tls.o
2023-12-06T09:32:01.6026152Z X509_LOOKUP_ctrl                    pppd-tls.o
2023-12-06T09:32:01.6026593Z ENGINE_register_all_complete        pppd-eap-tls.o
2023-12-06T09:32:01.6027053Z SSL_set_accept_state                pppd-eap-tls.o
2023-12-06T09:32:01.6027486Z BIO_s_mem                           pppd-eap-tls.o
2023-12-06T09:32:01.6027932Z BIO_write                           pppd-eap-tls.o
2023-12-06T09:32:01.6028359Z ENGINE_set_default                  pppd-eap-tls.o
2023-12-06T09:32:01.6028907Z EVP_CipherInit                      ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6029439Z SSL_CTX_set_verify_depth            pppd-tls.o
2023-12-06T09:32:01.6029876Z X509_STORE_set_flags                pppd-tls.o
2023-12-06T09:32:01.6030297Z SSL_set_connect_state               pppd-eap-tls.o
2023-12-06T09:32:01.6030723Z sk_pop_free                         pppd-eap-tls.o
2023-12-06T09:32:01.6031162Z SSL_CTX_use_certificate_chain_file  pppd-eap-tls.o
2023-12-06T09:32:01.6031620Z SSL_load_client_CA_file             pppd-eap-tls.o
2023-12-06T09:32:01.6032051Z SSL_CTX_use_PrivateKey              pppd-eap-tls.o
2023-12-06T09:32:01.6032475Z BIO_new                             pppd-eap-tls.o
2023-12-06T09:32:01.6032891Z SSL_CTX_get_cert_store              pppd-tls.o
2023-12-06T09:32:01.6033310Z sk_num                              pppd-eap-tls.o
2023-12-06T09:32:01.6033866Z EVP_CIPHER_CTX_free                 ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6034520Z EVP_DigestInit                      ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.6035047Z SSL_CTX_sess_set_new_cb             pppd-eap-tls.o
2023-12-06T09:32:01.6035686Z SSL_ctrl                            pppd-eap-tls.o
2023-12-06T09:32:01.6036200Z SSL_free                            pppd-eap-tls.o
2023-12-06T09:32:01.6037014Z SSL_read                            pppd-eap-tls.o
2023-12-06T09:32:01.6037794Z X509_cmp                            pppd-tls.o
2023-12-06T09:32:01.6038227Z SSL_new                             pppd-eap-tls.o
2023-12-06T09:32:01.6038645Z BIO_new_file                        pppd-eap-tls.o
2023-12-06T09:32:01.6039250Z SSL_CTX_new                         pppd-eap-tls.o
2023-12-06T09:32:01.6039675Z SSL_CTX_load_verify_locations       pppd-tls.o
2023-12-06T09:32:01.6040285Z SSL_set_bio                         pppd-eap-tls.o
2023-12-06T09:32:01.6041146Z SSL_export_keying_material          pppd-eap-tls.o
2023-12-06T09:32:01.6042030Z CONF_modules_load                   pppd-eap-tls.o
2023-12-06T09:32:01.6043125Z EVP_CipherFinal                     ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6044160Z RAND_bytes                          pppd-peap.o
2023-12-06T09:32:01.6044905Z SSL_set_msg_callback                pppd-eap-tls.o
2023-12-06T09:32:01.6045898Z EVP_DigestUpdate                    ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.6047140Z EVP_des_ecb                         ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6048213Z OPENSSL_load_builtin_modules        pppd-eap-tls.o
2023-12-06T09:32:01.6048789Z SSL_CTX_set_verify                  pppd-tls.o
2023-12-06T09:32:01.6049227Z X509_verify_cert_error_string       pppd-tls.o
2023-12-06T09:32:01.6049768Z EVP_md4                             ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md4.o)
2023-12-06T09:32:01.6050380Z EVP_md5                             ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.6050894Z UI_destroy_method                   pppd-eap-tls.o
2023-12-06T09:32:01.6051327Z X509_STORE_add_crl                  pppd-tls.o
2023-12-06T09:32:01.6051764Z ENGINE_load_builtin_engines         pppd-eap-tls.o
2023-12-06T09:32:01.6052223Z SSL_CTX_set_client_CA_list          pppd-eap-tls.o
2023-12-06T09:32:01.6052660Z EVP_sha1                            pppd-peap.o
2023-12-06T09:32:01.6053077Z X509_check_purpose                  pppd-tls.o
2023-12-06T09:32:01.6053588Z X509_STORE_CTX_get_error_depth      pppd-tls.o
2023-12-06T09:32:01.6054089Z SSL_CTX_use_certificate             pppd-eap-tls.o
2023-12-06T09:32:01.6054531Z SSL_CTX_ctrl                        pppd-eap-tls.o
2023-12-06T09:32:01.6054956Z SSL_CTX_free                        pppd-eap-tls.o
2023-12-06T09:32:01.6055384Z SSL_version                         pppd-eap-tls.o
2023-12-06T09:32:01.6056141Z EVP_DigestFinal                     ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.6057214Z SSL_get_certificate                 pppd-eap-tls.o
2023-12-06T09:32:01.6058012Z X509_STORE_CTX_get_current_cert     pppd-tls.o
2023-12-06T09:32:01.6058822Z SSL_get_ex_data_X509_STORE_CTX_idx  pppd-tls.o
2023-12-06T09:32:01.6059641Z UI_method_set_flusher               pppd-eap-tls.o
2023-12-06T09:32:01.6060475Z UI_method_set_reader                pppd-eap-tls.o
2023-12-06T09:32:01.6061323Z X509_STORE_CTX_get_error            pppd-tls.o
2023-12-06T09:32:01.6062342Z EVP_CIPHER_CTX_set_padding          ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.6063430Z UI_method_set_writer                pppd-eap-tls.o
2023-12-06T09:32:01.6064210Z BIO_ctrl                            pppd-peap.o
2023-12-06T09:32:01.6064940Z BIO_free                            pppd-eap-tls.o
2023-12-06T09:32:01.6065587Z BIO_read                            pppd-eap-tls.o
2023-12-06T09:32:01.6066282Z SSL_alert_desc_string_long          pppd-eap-tls.o
2023-12-06T09:32:01.6066948Z SSL_get_ex_data                     pppd-tls.o
2023-12-06T09:32:01.6067595Z UI_method_set_closer                pppd-eap-tls.o
2023-12-06T09:32:01.6068267Z d2i_PKCS12_bio                      pppd-eap-tls.o
2023-12-06T09:32:01.6068924Z SSLv23_method                       pppd-tls.o
2023-12-06T09:32:01.6069851Z SSL_set_ex_data                     pppd-tls.o
2023-12-06T09:32:01.6070507Z X509_STORE_CTX_get_ex_data          pppd-tls.o
2023-12-06T09:32:01.6071204Z SSL_CTX_check_private_key           pppd-eap-tls.o
2023-12-06T09:32:01.6072004Z UI_method_set_opener                pppd-eap-tls.o
2023-12-06T09:32:01.6072856Z UI_set_result                       pppd-eap-tls.o
2023-12-06T09:32:01.6073682Z X509_get_subject_name               pppd-eap-tls.o
2023-12-06T09:32:01.6074720Z SSL_library_init                    pppd-tls.o
2023-12-06T09:32:01.6075471Z X509_cmp_time                       pppd-eap-tls.o
2023-12-06T09:32:01.6076243Z ENGINE_by_id                        pppd-eap-tls.o
2023-12-06T09:32:01.6076874Z ld: fatal: symbol referencing errors
2023-12-06T09:32:01.6077241Z collect2: error: ld returned 1 exit status
2023-12-06T09:32:01.6077586Z *** Error code 1
2023-12-06T09:32:01.6077842Z The following command caused the error:
2023-12-06T09:32:01.6080792Z echo "  CCLD    " pppd;/bin/sh ../libtool --silent --tag=CC    --mode=link gcc  -Wno-deprecated-declarations -DSOL2 -DSRV4        -o pppd pppd-auth.o pppd-ccp.o  pppd-chap-md5.o pppd-chap.o  pppd-demand.o pppd-eap.o pppd-ecp.o  pppd-fsm.o pppd-ipcp.o pppd-lcp.o  pppd-magic.o pppd-main.o  pppd-options.o pppd-session.o  pppd-tty.o pppd-upap.o pppd-utils.o   pppd-sys-solaris.o pppd-chap_ms.o  pppd-crypto_ms.o    pppd-mppe.o    pppd-ipv6cp.o  pppd-eui64.o  pppd-eap-tls.o  pppd-tls.o  pppd-peap.o  -lsocket -lnsl   -ldl -lpam -ldl libppp_crypto.la    
2023-12-06T09:32:01.6083360Z make: Fatal error: Command failed for target `pppd'
2023-12-06T09:32:01.6083828Z Current working directory /home/runner/work/ppp/ppp/pppd
2023-12-06T09:32:01.6084216Z *** Error code 1
2023-12-06T09:32:01.6084757Z make: Fatal error: Command failed for target `all'
2023-12-06T09:32:01.6085645Z Current working directory /home/runner/work/ppp/ppp/pppd
2023-12-06T09:32:01.6095865Z *** Error code 1
2023-12-06T09:32:01.6096343Z The following command caused the error:
2023-12-06T09:32:01.6096907Z fail=; \
2023-12-06T09:32:01.6104275Z if (target_option=k; case ${target_option-} in  ?) ;;  *) echo "am__make_running_with_option: internal error: invalid"  "target option '${target_option-}' specified" >&2;  exit 1;;  esac;  has_opt=no;  sane_makeflags=$MAKEFLAGS;  if {  if test -z ''; then  false;  elif test -n ''; then  true;  elif test -n '' && test -n ''; then  true;  else  false;  fi;  }; then  sane_makeflags=$MFLAGS;  else  case $MAKEFLAGS in  *\\[\ \	]*)  bs=\\;  sane_makeflags=`printf '%s\n' "$MAKEFLAGS"  | sed "s/$bs$bs[$bs $bs	]*//g"`;;  esac;  fi;  skip_next=no;  strip_trailopt ()  {  flg=`printf '%s\n' "$flg" | sed "s/$1.*$//"`;  };  for flg in $sane_makeflags; do  test $skip_next = yes && { skip_next=no; continue; };  case $flg in  *=*|--*) continue;;  -*I) strip_trailopt 'I'; skip_next=yes;;  -*I?*) strip_trailopt 'I';;  -*O) strip_trailopt 'O'; skip_next=yes;;  -*O?*) strip_trailopt 'O';;  -*l) strip_trailopt 'l'; skip_next=yes;;  -*l?*) strip_trailopt 'l';;  -[dEDm]) skip_next=yes;;  -[JT]) skip_next=yes;;  esac;  case $flg in  *$target_option*) has_opt=yes; break;;  esac;  done;  test $has_opt = yes); then \
2023-12-06T09:32:01.6109833Z   failcom='fail=yes'; \
2023-12-06T09:32:01.6110104Z else \
2023-12-06T09:32:01.6110331Z   failcom='exit 1'; \
2023-12-06T09:32:01.6110578Z fi; \
2023-12-06T09:32:01.6110776Z dot_seen=no; \
2023-12-06T09:32:01.6111117Z target=`echo all-recursive | sed s/-recursive//`; \
2023-12-06T09:32:01.6111544Z case "all-recursive" in \
2023-12-06T09:32:01.6112280Z   distclean-* | maintainer-clean-*) list='chat contrib pppd pppstats pppdump pppd/plugins common include modules scripts' ;; \
2023-12-06T09:32:01.6113599Z   *) list='chat contrib pppd pppstats pppdump pppd/plugins' ;; \
2023-12-06T09:32:01.6114389Z esac; \
2023-12-06T09:32:01.6114797Z for subdir in $list; do \
2023-12-06T09:32:01.6115330Z   echo "Making $target in $subdir"; \
2023-12-06T09:32:01.6115925Z   if test "$subdir" = "."; then \
2023-12-06T09:32:01.6116809Z     dot_seen=yes; \
2023-12-06T09:32:01.6117395Z     local_target="$target-am"; \
2023-12-06T09:32:01.6117960Z   else \
2023-12-06T09:32:01.6118378Z     local_target="$target"; \
2023-12-06T09:32:01.6118883Z   fi; \
2023-12-06T09:32:01.6119496Z   (CDPATH="${ZSH_VERSION+.}:" && cd $subdir && make  $local_target) \
2023-12-06T09:32:01.6120620Z   || eval $failcom; \
2023-12-06T09:32:01.6121063Z done; \
2023-12-06T09:32:01.6121440Z if test "$dot_seen" = "no"; then \
2023-12-06T09:32:01.6122340Z   make  "$target-am" || exit 1; \
2023-12-06T09:32:01.6122894Z fi; test -z "$fail"
2023-12-06T09:32:01.6123625Z make: Fatal error: Command failed for target `all-recursive'
2023-12-06T09:32:01.6246494Z Making install in chat
2023-12-06T09:32:01.6473604Z  /usr/bin/gmkdir -p '/usr/local/sbin'
2023-12-06T09:32:01.6592169Z   /bin/sh ../libtool   --mode=install /usr/bin/ginstall -c chat '/usr/local/sbin'
2023-12-06T09:32:01.6783499Z libtool: install: /usr/bin/ginstall -c chat /usr/local/sbin/chat
2023-12-06T09:32:01.6891217Z  /usr/bin/gmkdir -p '/usr/local/share/man/man8'
2023-12-06T09:32:01.7044163Z  /usr/bin/ginstall -c -m 644 chat.8 '/usr/local/share/man/man8'
2023-12-06T09:32:01.7103438Z Making install in contrib
2023-12-06T09:32:01.7213569Z Making install in pppgetpass
2023-12-06T09:32:01.7504330Z Making install in pppd
2023-12-06T09:32:01.7895218Z   CCLD     pppd
2023-12-06T09:32:01.8872668Z Undefined			first referenced
2023-12-06T09:32:01.8873946Z  symbol  			    in file
2023-12-06T09:32:01.8876078Z HMAC                                pppd-peap.o
2023-12-06T09:32:01.8876939Z ERR_clear_error                     pppd-eap-tls.o
2023-12-06T09:32:01.8881111Z SSL_CTX_set_default_passwd_cb       pppd-eap-tls.o
2023-12-06T09:32:01.8888093Z SSL_load_error_strings              pppd-tls.o
2023-12-06T09:32:01.8888880Z EVP_PKEY_free                       pppd-eap-tls.o
2023-12-06T09:32:01.8889661Z UI_get0_user_data                   pppd-eap-tls.o
2023-12-06T09:32:01.8890427Z ENGINE_ctrl_cmd                     pppd-eap-tls.o
2023-12-06T09:32:01.8891211Z UI_create_method                    pppd-eap-tls.o
2023-12-06T09:32:01.8891948Z PEM_read_X509_CRL                   pppd-tls.o
2023-12-06T09:32:01.8892657Z SSL_do_handshake                    pppd-peap.o
2023-12-06T09:32:01.8893377Z X509_STORE_add_lookup               pppd-tls.o
2023-12-06T09:32:01.8897407Z sk_value                            pppd-eap-tls.o
2023-12-06T09:32:01.8898235Z ENGINE_ctrl_cmd_string              pppd-eap-tls.o
2023-12-06T09:32:01.8899076Z X509_NAME_oneline                   pppd-eap-tls.o
2023-12-06T09:32:01.8899872Z SSL_state                           pppd-eap.o
2023-12-06T09:32:01.8900621Z SSL_write                           pppd-peap.o
2023-12-06T09:32:01.8901467Z X509_NAME_get_text_by_NID           pppd-tls.o
2023-12-06T09:32:01.8902453Z EVP_CIPHER_CTX_new                  ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8903400Z NCONF_free                          pppd-eap-tls.o
2023-12-06T09:32:01.8904146Z NCONF_load                          pppd-eap-tls.o
2023-12-06T09:32:01.8904889Z SSL_get_error                       pppd-peap.o
2023-12-06T09:32:01.8905616Z ENGINE_free                         pppd-eap-tls.o
2023-12-06T09:32:01.8906343Z BIO_ctrl_pending                    pppd-peap.o
2023-12-06T09:32:01.8907072Z PKCS12_parse                        pppd-eap-tls.o
2023-12-06T09:32:01.8907792Z PEM_read_X509                       pppd-tls.o
2023-12-06T09:32:01.8908485Z ERR_error_string                    pppd-tls.o
2023-12-06T09:32:01.8909230Z ENGINE_load_private_key             pppd-eap-tls.o
2023-12-06T09:32:01.8910005Z X509_free                           pppd-eap-tls.o
2023-12-06T09:32:01.8910706Z ERR_get_error                       pppd-tls.o
2023-12-06T09:32:01.8911410Z NCONF_new                           pppd-eap-tls.o
2023-12-06T09:32:01.8912135Z PKCS12_free                         pppd-eap-tls.o
2023-12-06T09:32:01.8912877Z PEM_read_bio_PrivateKey             pppd-eap-tls.o
2023-12-06T09:32:01.8913865Z EVP_MD_CTX_create                   ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.8915441Z EVP_MD_CTX_destroy                  ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.8916590Z EVP_CipherUpdate                    ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8917510Z X509_LOOKUP_hash_dir                pppd-tls.o
2023-12-06T09:32:01.8918219Z X509_LOOKUP_ctrl                    pppd-tls.o
2023-12-06T09:32:01.8919165Z ENGINE_register_all_complete        pppd-eap-tls.o
2023-12-06T09:32:01.8920097Z SSL_set_accept_state                pppd-eap-tls.o
2023-12-06T09:32:01.8920861Z BIO_s_mem                           pppd-eap-tls.o
2023-12-06T09:32:01.8921588Z BIO_write                           pppd-eap-tls.o
2023-12-06T09:32:01.8927188Z ENGINE_set_default                  pppd-eap-tls.o
2023-12-06T09:32:01.8935253Z EVP_CipherInit                      ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8936583Z SSL_CTX_set_verify_depth            pppd-tls.o
2023-12-06T09:32:01.8937437Z X509_STORE_set_flags                pppd-tls.o
2023-12-06T09:32:01.8938234Z SSL_set_connect_state               pppd-eap-tls.o
2023-12-06T09:32:01.8939041Z sk_pop_free                         pppd-eap-tls.o
2023-12-06T09:32:01.8939817Z SSL_CTX_use_certificate_chain_file  pppd-eap-tls.o
2023-12-06T09:32:01.8940718Z SSL_load_client_CA_file             pppd-eap-tls.o
2023-12-06T09:32:01.8941478Z SSL_CTX_use_PrivateKey              pppd-eap-tls.o
2023-12-06T09:32:01.8942240Z BIO_new                             pppd-eap-tls.o
2023-12-06T09:32:01.8942933Z SSL_CTX_get_cert_store              pppd-tls.o
2023-12-06T09:32:01.8943631Z sk_num                              pppd-eap-tls.o
2023-12-06T09:32:01.8944568Z EVP_CIPHER_CTX_free                 ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8945704Z EVP_DigestInit                      ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.8946611Z SSL_CTX_sess_set_new_cb             pppd-eap-tls.o
2023-12-06T09:32:01.8947310Z SSL_ctrl                            pppd-eap-tls.o
2023-12-06T09:32:01.8947987Z SSL_free                            pppd-eap-tls.o
2023-12-06T09:32:01.8948669Z SSL_read                            pppd-eap-tls.o
2023-12-06T09:32:01.8949330Z X509_cmp                            pppd-tls.o
2023-12-06T09:32:01.8949977Z SSL_new                             pppd-eap-tls.o
2023-12-06T09:32:01.8950653Z BIO_new_file                        pppd-eap-tls.o
2023-12-06T09:32:01.8951331Z SSL_CTX_new                         pppd-eap-tls.o
2023-12-06T09:32:01.8952027Z SSL_CTX_load_verify_locations       pppd-tls.o
2023-12-06T09:32:01.8952896Z SSL_set_bio                         pppd-eap-tls.o
2023-12-06T09:32:01.8953472Z SSL_export_keying_material          pppd-eap-tls.o
2023-12-06T09:32:01.8953945Z CONF_modules_load                   pppd-eap-tls.o
2023-12-06T09:32:01.8954521Z EVP_CipherFinal                     ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8955078Z RAND_bytes                          pppd-peap.o
2023-12-06T09:32:01.8955506Z SSL_set_msg_callback                pppd-eap-tls.o
2023-12-06T09:32:01.8956068Z EVP_DigestUpdate                    ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.8956723Z EVP_des_ecb                         ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8957600Z OPENSSL_load_builtin_modules        pppd-eap-tls.o
2023-12-06T09:32:01.8958420Z SSL_CTX_set_verify                  pppd-tls.o
2023-12-06T09:32:01.8959255Z X509_verify_cert_error_string       pppd-tls.o
2023-12-06T09:32:01.8960482Z EVP_md4                             ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md4.o)
2023-12-06T09:32:01.8961732Z EVP_md5                             ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.8962751Z UI_destroy_method                   pppd-eap-tls.o
2023-12-06T09:32:01.8963565Z X509_STORE_add_crl                  pppd-tls.o
2023-12-06T09:32:01.8964673Z ENGINE_load_builtin_engines         pppd-eap-tls.o
2023-12-06T09:32:01.8965514Z SSL_CTX_set_client_CA_list          pppd-eap-tls.o
2023-12-06T09:32:01.8966274Z EVP_sha1                            pppd-peap.o
2023-12-06T09:32:01.8966926Z X509_check_purpose                  pppd-tls.o
2023-12-06T09:32:01.8967563Z X509_STORE_CTX_get_error_depth      pppd-tls.o
2023-12-06T09:32:01.8968267Z SSL_CTX_use_certificate             pppd-eap-tls.o
2023-12-06T09:32:01.8969222Z SSL_CTX_ctrl                        pppd-eap-tls.o
2023-12-06T09:32:01.8970061Z SSL_CTX_free                        pppd-eap-tls.o
2023-12-06T09:32:01.8970739Z SSL_version                         pppd-eap-tls.o
2023-12-06T09:32:01.8971607Z EVP_DigestFinal                     ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-md5.o)
2023-12-06T09:32:01.8972454Z SSL_get_certificate                 pppd-eap-tls.o
2023-12-06T09:32:01.8973124Z X509_STORE_CTX_get_current_cert     pppd-tls.o
2023-12-06T09:32:01.8973771Z SSL_get_ex_data_X509_STORE_CTX_idx  pppd-tls.o
2023-12-06T09:32:01.8974474Z UI_method_set_flusher               pppd-eap-tls.o
2023-12-06T09:32:01.8975198Z UI_method_set_reader                pppd-eap-tls.o
2023-12-06T09:32:01.8975900Z X509_STORE_CTX_get_error            pppd-tls.o
2023-12-06T09:32:01.8976850Z EVP_CIPHER_CTX_set_padding          ./.libs/libppp_crypto.a(libppp_crypto_la-ppp-des.o)
2023-12-06T09:32:01.8977745Z UI_method_set_writer                pppd-eap-tls.o
2023-12-06T09:32:01.8978451Z BIO_ctrl                            pppd-peap.o
2023-12-06T09:32:01.8979168Z BIO_free                            pppd-eap-tls.o
2023-12-06T09:32:01.8979890Z BIO_read                            pppd-eap-tls.o
2023-12-06T09:32:01.8980529Z SSL_alert_desc_string_long          pppd-eap-tls.o
2023-12-06T09:32:01.8980959Z SSL_get_ex_data                     pppd-tls.o
2023-12-06T09:32:01.8981381Z UI_method_set_closer                pppd-eap-tls.o
2023-12-06T09:32:01.8981817Z d2i_PKCS12_bio                      pppd-eap-tls.o
2023-12-06T09:32:01.8982230Z SSLv23_method                       pppd-tls.o
2023-12-06T09:32:01.8982639Z SSL_set_ex_data                     pppd-tls.o
2023-12-06T09:32:01.8983048Z X509_STORE_CTX_get_ex_data          pppd-tls.o
2023-12-06T09:32:01.8983466Z SSL_CTX_check_private_key           pppd-eap-tls.o
2023-12-06T09:32:01.8983911Z UI_method_set_opener                pppd-eap-tls.o
2023-12-06T09:32:01.8984344Z UI_set_result                       pppd-eap-tls.o
2023-12-06T09:32:01.8984766Z X509_get_subject_name               pppd-eap-tls.o
2023-12-06T09:32:01.8985189Z SSL_library_init                    pppd-tls.o
2023-12-06T09:32:01.8985604Z X509_cmp_time                       pppd-eap-tls.o
2023-12-06T09:32:01.8986032Z ENGINE_by_id                        pppd-eap-tls.o
2023-12-06T09:32:01.8986412Z ld: fatal: symbol referencing errors
2023-12-06T09:32:01.8986771Z collect2: error: ld returned 1 exit status
2023-12-06T09:32:01.8987103Z *** Error code 1
2023-12-06T09:32:01.8987366Z The following command caused the error:
2023-12-06T09:32:01.8990718Z echo "  CCLD    " pppd;/bin/sh ../libtool --silent --tag=CC    --mode=link gcc  -Wno-deprecated-declarations -DSOL2 -DSRV4        -o pppd pppd-auth.o pppd-ccp.o  pppd-chap-md5.o pppd-chap.o  pppd-demand.o pppd-eap.o pppd-ecp.o  pppd-fsm.o pppd-ipcp.o pppd-lcp.o  pppd-magic.o pppd-main.o  pppd-options.o pppd-session.o  pppd-tty.o pppd-upap.o pppd-utils.o   pppd-sys-solaris.o pppd-chap_ms.o  pppd-crypto_ms.o    pppd-mppe.o    pppd-ipv6cp.o  pppd-eui64.o  pppd-eap-tls.o  pppd-tls.o  pppd-peap.o  -lsocket -lnsl   -ldl -lpam -ldl libppp_crypto.la    
2023-12-06T09:32:01.8995530Z make: Fatal error: Command failed for target `pppd'
2023-12-06T09:32:01.8996326Z Current working directory /home/runner/work/ppp/ppp/pppd
2023-12-06T09:32:01.9003155Z *** Error code 1
2023-12-06T09:32:01.9003611Z The following command caused the error:
2023-12-06T09:32:01.9004256Z fail=; \
2023-12-06T09:32:01.9011480Z if (target_option=k; case ${target_option-} in  ?) ;;  *) echo "am__make_running_with_option: internal error: invalid"  "target option '${target_option-}' specified" >&2;  exit 1;;  esac;  has_opt=no;  sane_makeflags=$MAKEFLAGS;  if {  if test -z ''; then  false;  elif test -n ''; then  true;  elif test -n '' && test -n ''; then  true;  else  false;  fi;  }; then  sane_makeflags=$MFLAGS;  else  case $MAKEFLAGS in  *\\[\ \	]*)  bs=\\;  sane_makeflags=`printf '%s\n' "$MAKEFLAGS"  | sed "s/$bs$bs[$bs $bs	]*//g"`;;  esac;  fi;  skip_next=no;  strip_trailopt ()  {  flg=`printf '%s\n' "$flg" | sed "s/$1.*$//"`;  };  for flg in $sane_makeflags; do  test $skip_next = yes && { skip_next=no; continue; };  case $flg in  *=*|--*) continue;;  -*I) strip_trailopt 'I'; skip_next=yes;;  -*I?*) strip_trailopt 'I';;  -*O) strip_trailopt 'O'; skip_next=yes;;  -*O?*) strip_trailopt 'O';;  -*l) strip_trailopt 'l'; skip_next=yes;;  -*l?*) strip_trailopt 'l';;  -[dEDm]) skip_next=yes;;  -[JT]) skip_next=yes;;  esac;  case $flg in  *$target_option*) has_opt=yes; break;;  esac;  done;  test $has_opt = yes); then \
2023-12-06T09:32:01.9016180Z   failcom='fail=yes'; \
2023-12-06T09:32:01.9016641Z else \
2023-12-06T09:32:01.9017107Z   failcom='exit 1'; \
2023-12-06T09:32:01.9017582Z fi; \
2023-12-06T09:32:01.9017951Z dot_seen=no; \
2023-12-06T09:32:01.9018654Z target=`echo install-recursive | sed s/-recursive//`; \
2023-12-06T09:32:01.9019512Z case "install-recursive" in \
2023-12-06T09:32:01.9020956Z   distclean-* | maintainer-clean-*) list='chat contrib pppd pppstats pppdump pppd/plugins common include modules scripts' ;; \
2023-12-06T09:32:01.9022649Z   *) list='chat contrib pppd pppstats pppdump pppd/plugins' ;; \
2023-12-06T09:32:01.9023119Z esac; \
2023-12-06T09:32:01.9023332Z for subdir in $list; do \
2023-12-06T09:32:01.9023629Z   echo "Making $target in $subdir"; \
2023-12-06T09:32:01.9023956Z   if test "$subdir" = "."; then \
2023-12-06T09:32:01.9024245Z     dot_seen=yes; \
2023-12-06T09:32:01.9024783Z     local_target="$target-am"; \
2023-12-06T09:32:01.9025313Z   else \
2023-12-06T09:32:01.9025717Z     local_target="$target"; \
2023-12-06T09:32:01.9026242Z   fi; \
2023-12-06T09:32:01.9026846Z   (CDPATH="${ZSH_VERSION+.}:" && cd $subdir && make  $local_target) \
2023-12-06T09:32:01.9027483Z   || eval $failcom; \
2023-12-06T09:32:01.9027734Z done; \
2023-12-06T09:32:01.9027958Z if test "$dot_seen" = "no"; then \
2023-12-06T09:32:01.9028333Z   make  "$target-am" || exit 1; \
2023-12-06T09:32:01.9028653Z fi; test -z "$fail"
2023-12-06T09:32:01.9029065Z make: Fatal error: Command failed for target `install-recursive'

[Neustradamus]

@paulusmack, @enaess, @carlsonj, @jkroonza: Can you look for Solaris problem?

@RICCIARDI-Adrien has added the log...

[jkroonza]

I don't have Solaris, nor a way to reproduce, but looking at the above it looks like the linker is for some reason not pulling in the openssl libraries.

We should probably log a separate issue to deal with the warning around volatile, which likely applies to Linux too and should be addressed (probably dropping the volatile keyword should be enough - https://www.kernel.org/doc/html/next/process/volatile-considered-harmful.html - I'm not 100% confident stating that it applies but the logic certainly makes sense, however https://www.embedded.com/introduction-to-the-volatile-keyword/ does give the cases where we want to use volatile, if we do actually need volatile we can likely just cast it away here).

[paulusmack]

Right, the failing link command doesn't include any mention of any SSL library.

I see the following in the log during the configure phase:

2023-12-06T09:31:56.1744641Z checking whether compiling and linking against OpenSSL works... no
2023-12-06T09:31:56.1913753Z checking for md4 support in openssl... yes
2023-12-06T09:31:56.2064523Z checking for md5 support in openssl... yes
2023-12-06T09:31:56.2223841Z checking for des support in openssl... yes
2023-12-06T09:31:56.2383972Z checking for sha support in openssl... yes

(the first line there looks suspicious to me)

and later, in the configuration summary:

2023-12-06T09:31:58.0585513Z     With OpenSSL.........: yes

@enaess why is there no SSL library on the link command line? Why does configure think we are using OpenSSL when apparently compiling and linking against OpenSSL doesn't work?

[enaess]

@paulusmack Looks like there was a bug in the ax_check_openssl.m4 where the if condition failed to trigger and search for the right include path. Solaris-11.4 has two versions of openssl (default is 1.0.0 and is compiled with FIPS module support), then openssl-11 is 1.0.2l. They are installed in /usr/openssl/default or /usr/openssl/1.1 respectively. Send you a new PR where configure should be able to pick up the default version by testing the presence of /usr/include/openssl/ssl.h

[Neustradamus]

@enaess: @paulusmack has been merged your PR:

• Fixing a problem where the detection of openssl failed on solaris #468

@ all : Now it is good for Solaris?

[enaess]

@Neustradamus Looks like the latest merge/ci-build as of 2 hours ago completed with the Solaris checks succeeding.

[Neustradamus]

@enaess: Good job with @RICCIARDI-Adrien!