-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test PR: Removed problematic code. #66
base: master
Are you sure you want to change the base?
Conversation
@@ -1,8 +1,3 @@ | |||
if ( $env:VisualStudioVersion -eq $null ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me, I don't see why would it need to be removed.
Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Microsoft.VisualStudio.DevShell.dll" | ||
Enter-VsDevShell -VsInstallPath "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\" -StartInPath $(Get-Location) | ||
} | ||
|
||
(& dotnet nuget locals http-cache -c) | Out-Null | ||
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args | ||
exit $LASTEXITCODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test: maybe keep
Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible. |
Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Microsoft.VisualStudio.DevShell.dll" | ||
Enter-VsDevShell -VsInstallPath "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\" -StartInPath $(Get-Location) | ||
} | ||
|
||
(& dotnet nuget locals http-cache -c) | Out-Null | ||
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test: Ok. Good change
Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible. |
Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Microsoft.VisualStudio.DevShell.dll" | ||
Enter-VsDevShell -VsInstallPath "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\" -StartInPath $(Get-Location) | ||
} | ||
|
||
(& dotnet nuget locals http-cache -c) | Out-Null | ||
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST review
Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible. |
Test