Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR: Removed problematic code. #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aweneer
Copy link
Contributor

@aweneer aweneer commented Aug 29, 2022

Test

@@ -1,8 +1,3 @@
if ( $env:VisualStudioVersion -eq $null ) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, I don't see why would it need to be removed.

Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Microsoft.VisualStudio.DevShell.dll"
Enter-VsDevShell -VsInstallPath "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\" -StartInPath $(Get-Location)
}

(& dotnet nuget locals http-cache -c) | Out-Null
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args
exit $LASTEXITCODE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: maybe keep

@PostSharpBot
Copy link
Member

Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible.
Note to the PostSharp team, this ticket is being tracked in our dashboard under ID TP-30992.

Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Microsoft.VisualStudio.DevShell.dll"
Enter-VsDevShell -VsInstallPath "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\" -StartInPath $(Get-Location)
}

(& dotnet nuget locals http-cache -c) | Out-Null
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: Ok. Good change

@PostSharpBot
Copy link
Member

Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible.
Note to the PostSharp team, this ticket is being tracked in our dashboard under ID TP-30997.

Import-Module "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\Microsoft.VisualStudio.DevShell.dll"
Enter-VsDevShell -VsInstallPath "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\" -StartInPath $(Get-Location)
}

(& dotnet nuget locals http-cache -c) | Out-Null
& dotnet run --project "$PSScriptRoot\eng\src\BuildGitHubTestProduct.csproj" -- $args

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST review

@PostSharpBot
Copy link
Member

Hello @TestCommenter, thank you for submitting this pull request review. We will try to get back to you as soon as possible.
Note to the PostSharp team, this ticket is being tracked in our dashboard under ID TP-30999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants