Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python: rename midi file type to audio/midi #756

Merged

Conversation

Pranav2612000
Copy link
Contributor

@Pranav2612000 Pranav2612000 commented Jul 18, 2024

Issue: postmanlabs/postman-app-support#10432

There was a typo in the fileType header maps causing .mid files to be set as audip/midi instead of audio/midi. This commit fixes the typo.

Specification for supported Header MIME types: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types ( This doesn't include audip/midi so we can be sure that it is a typo ).

Screenshots

Previous:
HTTP
image

Python3 - Requests
image

After:
HTTP:
image

Python3 - Requests
image

There was a typo in the fileType header maps causing .mid files
to be set as audip/midi instead of audio/midi. This commit fixes
the typo.
@VShingala VShingala self-requested a review July 19, 2024 13:15
@VShingala VShingala merged commit 74d1269 into postmanlabs:develop Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants