Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment cache should include requirements.txt containing package versions #9

Open
schloerke opened this issue Jan 10, 2024 · 0 comments · May be fixed by #10
Open

Deployment cache should include requirements.txt containing package versions #9

schloerke opened this issue Jan 10, 2024 · 0 comments · May be fixed by #10
Assignees

Comments

@schloerke
Copy link

schloerke commented Jan 10, 2024

I believe there needs to be a step where we install the app packages.

Then we should also include the installed packages in the cache path.

          path: |
            ${{ matrix.folder }}
            INSTALL_PATH_HERE

IDK what the Install location is for the python packages


Motivation: We cache both the shiny code and the app content

Originally posted by @schloerke in #8 (comment)


Oh that's a good point, what about including the shiny version in the requirements.txt file instead? I'll add an issue.

@gshotwell gshotwell linked a pull request Jan 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants