-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta Tags, OpenGraph and Twitter Cards #548
Conversation
✅ Deploy Preview for pony-tutorial ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
One of my favorite things about when we moved from the Hugo theme I did that supported meta tags and twitter cards was that we didn't have to try to come up with descriptions for every page. It was a slog in some cases. We will discuss at sync and perhaps other maintainers will see the value. I personally have been down the road of this already with our old setup and I didn't see the value in it. It was just extra work, extra stuff to maintain so I'm not in favor, but others might be. Will update further after our next sync call. Thanks for opening this PR Sebastian. Your commitment to improving the tutorial has been impressive and inspiring to watch as the updates flow into my inbox. |
You unfortunaly see it from a slightly "wrong" angle. I totally see, that you don't want to write these descriptions. But I wouldn't call a SSG engine "better" when it is lacking a fairly standard feature, just because I personally don't like the work that goes into it and I, unlike many other people, don't use that feature. Sorry if I'm out of line here. |
Can the title come from the H1 in the page? Having in metadata, it could get out of sync. |
It could. However, as you see, this works fine on page but less so more often than not taken out of context as it will be when sent as a link. |
Can it come from the existing breadcrumb stuff in mkdocs? |
I'm in agreement with @SeanTAllen on this point. I admit that having page-specific information in the Card can be useful for someone glancing quickly card but it's a fairly small amount of value and I don't think it outweighs the maintenance effort being added. Here are my concrete set of concerns:
Some alternative ideas discussed in sync:
|
Maybe, I didn't explain my concerns in a reasonable way: For example: Do you know how many pages named "Overview" we have? Quite a few, actually. This raises the question: Overview of what? So, this gives the user essentially nothing. Does that make it a little clearer?
@SeanTAllen Sounds good 👍🏻 I made the necessary changes
@jemc This isn't really a compromise. This essentially has the same problem as a generic description for the entire tutorial. It doesn't say what's on the page. I wouldn't go as far as saying that this way we lie to the user but we get close to it by not telling them where the link actually leads to and instead claim, the entire chapter was just one page. And as you were worried about Google/SEO: I'm not entirely sure how Google actually determines that but multiple pages with the same description could be seen as "duplicate content", which that would have a negative impact on the SEO. |
See #546 (comment) |
Fixes #546